feat(blink-cmp): add integration #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgoudham
reviewed
Oct 19, 2024
Comment on lines
13
to
37
| BlinkCmpKindText = { fg = C.teal }, | ||
| BlinkCmpKindMethod = { fg = C.blue }, | ||
| BlinkCmpKindFunction = { fg = C.blue }, | ||
| BlinkCmpKindConstructor = { fg = C.blue }, | ||
| BlinkCmpKindField = { fg = C.green }, | ||
| BlinkCmpKindVariable = { fg = C.flamingo }, | ||
| BlinkCmpKindClass = { fg = C.yellow }, | ||
| BlinkCmpKindInterface = { fg = C.yellow }, | ||
| BlinkCmpKindModule = { fg = C.blue }, | ||
| BlinkCmpKindProperty = { fg = C.green }, | ||
| BlinkCmpKindUnit = { fg = C.green }, | ||
| BlinkCmpKindValue = { fg = C.peach }, | ||
| BlinkCmpKindEnum = { fg = C.green }, | ||
| BlinkCmpKindKeyword = { fg = C.red }, | ||
| BlinkCmpKindSnippet = { fg = C.mauve }, | ||
| BlinkCmpKindColor = { fg = C.red }, | ||
| BlinkCmpKindFile = { fg = C.blue }, | ||
| BlinkCmpKindReference = { fg = C.red }, | ||
| BlinkCmpKindFolder = { fg = C.blue }, | ||
| BlinkCmpKindEnumMember = { fg = C.red }, | ||
| BlinkCmpKindConstant = { fg = C.peach }, | ||
| BlinkCmpKindStruct = { fg = C.blue }, | ||
| BlinkCmpKindEvent = { fg = C.blue }, | ||
| BlinkCmpKindOperator = { fg = C.blue }, | ||
| BlinkCmpKindTypeParameter = { fg = C.blue }, |
There was a problem hiding this comment.
It would be good to double check that we are aligned as can be with the style guide for these highlights.
For example, Enum members/variants should be teal, Operators should be sky, etc.
There was a problem hiding this comment.
Thanks, I didn't know about that doc, maybe it should be linked to this repo README in some way?
I used the same colors as those used in the cmp integration, will change them based on the style guide then
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
giuxtaposition
force-pushed
the
blink-cmp
branch
from
adc463b
to
7445727
Compare
vollowx
approved these changes
Oct 26, 2024
vollowx
requested changes
Oct 26, 2024
vollowx
approved these changes
Oct 26, 2024
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added integration for blink.cmp.
Before:
After:
