From fdf58b410e152d0e2958348839d33e89a1b27959 Mon Sep 17 00:00:00 2001 From: Ben Dichter Date: Sun, 12 May 2024 21:26:38 -0400 Subject: [PATCH] drop python 3.8 (#325) * drop python 3.8 * fix typo * Update CHANGELOG.md * Update CHANGELOG.md * fix typo --- .github/ISSUE_TEMPLATE/bug_report.yml | 2 +- .github/workflows/auto-publish.yml | 2 +- .github/workflows/dev-testing.yaml | 2 +- .github/workflows/run-tests.yml | 2 +- CHANGELOG.md | 8 ++++++-- src/roiextractors/__init__.py | 12 ++---------- 6 files changed, 12 insertions(+), 16 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index c93809f6..8f675ea8 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -60,7 +60,7 @@ body: attributes: label: Python Version options: - - "3.8" + - "3.8 (no longer supported)" - "3.9" - "3.10" - "3.11" diff --git a/.github/workflows/auto-publish.yml b/.github/workflows/auto-publish.yml index dd44b7fb..74860b92 100644 --- a/.github/workflows/auto-publish.yml +++ b/.github/workflows/auto-publish.yml @@ -15,7 +15,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v2 with: - python-version: "3.8" + python-version: "3.9" - name: Install dependencies run: | python -m pip install --upgrade pip diff --git a/.github/workflows/dev-testing.yaml b/.github/workflows/dev-testing.yaml index 72bf6e0d..65d595ff 100644 --- a/.github/workflows/dev-testing.yaml +++ b/.github/workflows/dev-testing.yaml @@ -14,7 +14,7 @@ jobs: strategy: fail-fast: false matrix: - python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] + python-version: ["3.9", "3.10", "3.11", "3.12"] steps: - uses: actions/checkout@v4 - run: git fetch --prune --unshallow --tags diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 33ebeb59..02c709bd 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -31,7 +31,7 @@ jobs: strategy: fail-fast: false matrix: - python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] + python-version: ["3.9", "3.10", "3.11", "3.12"] os: [ubuntu-latest, windows-latest, macos-latest, macos-13] # macos-13 is the latest version of macOS with Intel chip steps: - uses: actions/checkout@v4 diff --git a/CHANGELOG.md b/CHANGELOG.md index c925eeee..3b810c03 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,8 @@ -# Upcoming +# Upcoming (v0.6.0) + +### Back-compatibility break + +* Remove support for Python 3.8 [PR #325](https://github.com/catalystneuro/roiextractors/pull/325) ### Features @@ -6,7 +10,7 @@ ### Fixes -* Remove unecessary scipy import error handling [#315]((https://github.com/catalystneuro/roiextractors/pull/315) +* Remove unecessary scipy import error handling [#315](https://github.com/catalystneuro/roiextractors/pull/315) * Added daily testing workflow and fixed bug with python 3.12 by upgrading scanimage-tiff-reader version: [PR #321](https://github.com/catalystneuro/roiextractors/pull/321) diff --git a/src/roiextractors/__init__.py b/src/roiextractors/__init__.py index a708f1d2..1f7ec5be 100644 --- a/src/roiextractors/__init__.py +++ b/src/roiextractors/__init__.py @@ -1,16 +1,8 @@ """Python-based module for extracting from, converting between, and handling recorded and optical imaging data from several file formats.""" -# Keeping __version__ accessible only to maintain backcompatability. -# Modern approach (Python >= 3.8) is to use importlib -try: - from importlib.metadata import version - - __version__ = version("roiextractors") -except ModuleNotFoundError: # Remove the except clause when minimal supported version becomes 3.8 - from pkg_resources import get_distribution - - __version__ = get_distribution("roiextractors").version +from importlib.metadata import version +__version__ = version("roiextractors") from .example_datasets import toy_example from .extraction_tools import show_video