From 4d98f317aab93c0a7069e7f07292ece13039a8f9 Mon Sep 17 00:00:00 2001 From: Cody Baker <51133164+CodyCBakerPhD@users.noreply.github.com> Date: Thu, 20 Jun 2024 16:32:31 -0400 Subject: [PATCH] Add packaging to minimal with test (#347) * add test for packaging * properly adjust first minimal * add packaging to minimal * Update CHANGELOG.md --- .github/workflows/run-tests.yml | 6 +++++- CHANGELOG.md | 1 + requirements-minimal.txt | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index d215eed0..83ee4329 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -30,8 +30,12 @@ jobs: git config --global user.name "CI Almighty" - name: Install roiextractors with minimal requirements - run: pip install .[test] + run: pip install . + - name: Test initial import of all non-lazy dependencies + run: python -c "import roiextractors" + - name: Install roiextractors with testing requirements + run: pip install .[test] - name: Run minimal tests run: pytest tests/test_internals -n auto --dist loadscope diff --git a/CHANGELOG.md b/CHANGELOG.md index 5455386e..8f95f9b3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ * Fixed the Daily testing workflows by passing along the appropriate secrets: [#340](https://github.com/catalystneuro/roiextractors/pull/340) * Change the criteria of determining if Bruker data is volumetric [#342](https://github.com/catalystneuro/roiextractors/pull/342) * Fixes a bug that assumes the channel name is is on the tiff file for `BrukerTiffSinglePlaneImagingExtractor` [#343](https://github.com/catalystneuro/roiextractors/pull/343) +* Including `packaging` explicitly in minimal requirements [#347](https://github.com/catalystneuro/roiextractors/pull/347) ### Improvements diff --git a/requirements-minimal.txt b/requirements-minimal.txt index e210d142..6a8d39d7 100644 --- a/requirements-minimal.txt +++ b/requirements-minimal.txt @@ -7,3 +7,4 @@ scipy>=1.5.2 psutil>=5.8.0 PyYAML lxml +packaging