-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we write ImageSeries
in external_mode if the timestamps are well specified
#472
Comments
The As far as PyNWB, no I don't think it's a strict requirement, or even technically a best practice just yet, but I think it's a 'highly recommended' strategy The closest mention we get is in the code https://github.com/NeurodataWithoutBorders/pynwb/blob/a6fa9170f2ad6942d74eaf44c22cedf0b80f0fcd/src/pynwb/image.py#L82-L90 |
No, but if you have the timestamps, this should not matter right? As in, you know at what time in your experiment each of the frames in the TimeSeries occured. |
It's not just about the timing of the frames, it's valuable context about how the shape of the total ImageSeries is distributed across the external files Example: one very short video and one very long one - nearly contiguous but slightly irregular timestamps - timestamps alone do not tell you exactly which frames of the timestamp vector correspond to which video file |
OK, thanks, I undestand that is very important information. The logic as I understand it now is that: an external file with wihout information would be very incomplete, so we don't let you, even if you could. |
As I currently understand it NWB-schema: this is an optional field |
Right, I guess we are moving towards there in #464 |
Right now when external mode is chosen we have the starting frames as a requirement:
neuroconv/src/neuroconv/datainterfaces/behavior/video/videodatainterface.py
Lines 327 to 329 in 2da9f6b
That is, for ImageSeries of multiple videos in external mode, we add the requirements of starting_frames. Is this necessary? I can't see any of this specified on pynwb:
https://pynwb.readthedocs.io/en/stable/pynwb.image.html
What is the logic here?
My feeling is that if the timestamps are well specfiied then we should be able to write the ImageSeries.
The text was updated successfully, but these errors were encountered: