Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VideoInterface #182

Open
2 of 7 tasks
h-mayorquin opened this issue Oct 19, 2022 · 1 comment
Open
2 of 7 tasks

Improve VideoInterface #182

h-mayorquin opened this issue Oct 19, 2022 · 1 comment

Comments

@h-mayorquin
Copy link
Collaborator

h-mayorquin commented Oct 19, 2022

Writing here a series of tasks to do for improving the movie interface:

  • Add an example to the conversion gallery Add VideoInterface to conversion gallery #183
  • Add timestamps stubbing. stub Movie interface timestamps #181
  • Add another interface that converts a single movie file. The one we have now takes a list of movies and iterates over each one. Having a single movie interface would allow a simpler API for users, be easier to test, and allow us to do a good refactor of the current one
  • Add a video example with variable rate to the gin-tests. Timestamp extraction and use with variable timestamps is not used..
  • Add an example of the single movie interface to the conversion gallery. I think this case is way more common and does not require the users to wrap their file paths into a list.
  • Separate the backend extraction from the conversion code. Right now the code for writing to nwb is tangled and mixed with the code for extracting properties from the videos with OpenCV. It is good practice to reduce the point of contact between functions (interfaces should touch each other at one place). This will simplify the code and if done well allow us to change the backend when needed without big headaches.
  • Some videos have a starting time than OpenCV does not extract. We should look for an example of this, add it to gin tests and extract it automatically.
@h-mayorquin h-mayorquin self-assigned this Oct 19, 2022
@h-mayorquin h-mayorquin changed the title Improve MovieInterface Improve VideoInterface Oct 24, 2022
@pauladkisson
Copy link
Member

Encountered some of these issues in the datta lab conversion: catalystneuro/datta-lab-to-nwb#56. VideoInterface could definitely use some love.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants