Improve temporally_align_data_interfaces #1162
Open
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No, but after the next release, we will make breaking changes so the next should be 0.7.0 anyway. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
+ Coverage 90.69% 90.75% +0.05%
==========================================
Files 129 129
Lines 8189 8285 +96
==========================================
+ Hits 7427 7519 +92
- Misses 762 766 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1161
Unfortunately, this will break back-compatibility for anyone who implemented their own version of
temporally_align_data_interfacesw/o re-implementingrun_conversion. So, probably needs to be slated for 0.7.0.@h-mayorquin, do you have a list of TODOs for 0.7.0 or a branch or something so that it doesn't get lost?