Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: NWBConverter.temporally_align_data_interfaces() should take metadata and conversion_options as kwargs #1161

Open
2 tasks done
pauladkisson opened this issue Dec 17, 2024 · 3 comments · May be fixed by #1162
Open
2 tasks done

Comments

@pauladkisson
Copy link
Member

What would you like to see added to NeuroConv?

I often need access to info in the metadata and/or conversion_options for temporal alignment, but in order to do so, I have to redefine run_conversion with this info passed on to temporally_align_data_interfaces. By providing this info in our default implementation it would reduce duplicate code.

Is your feature request related to a problem?

No response

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@h-mayorquin
Copy link
Collaborator

Can you provide an example of where this is necessary to illustrate the issue?

@pauladkisson
Copy link
Member Author

@h-mayorquin
Copy link
Collaborator

h-mayorquin commented Dec 17, 2024

Please link the specific lines and add some description. That's way more efficient than me or someone else digging into conversion code we are not familiar with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants