Fix chunking bug with compound dtypes #1146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rly, lmk what you think |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
==========================================
+ Coverage 90.69% 90.76% +0.07%
==========================================
Files 129 129
Lines 8189 8318 +129
==========================================
+ Hits 7427 7550 +123
- Misses 762 768 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1122
Comapare Dev Tests after the fix: https://github.com/catalystneuro/neuroconv/actions/runs/12171065620/job/33947262987
To Dev Tests before: https://github.com/catalystneuro/neuroconv/actions/runs/12152927667/job/33890176686 (774 failed)
Edit: Still have work to do based on the errors in the new dev tests