From 905dc73b549ce877487401d9dbcb67ebebff4e8d Mon Sep 17 00:00:00 2001 From: Heberto Mayorquin Date: Fri, 30 Aug 2024 18:49:01 -0600 Subject: [PATCH] Fix broken link to hdf5 documentation about IO optimization (#1044) --- .../tools/roiextractors/imagingextractordatachunkiterator.py | 4 ++-- .../spikeinterfacerecordingdatachunkiterator.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/neuroconv/tools/roiextractors/imagingextractordatachunkiterator.py b/src/neuroconv/tools/roiextractors/imagingextractordatachunkiterator.py index 0792e2caf..506967be0 100644 --- a/src/neuroconv/tools/roiextractors/imagingextractordatachunkiterator.py +++ b/src/neuroconv/tools/roiextractors/imagingextractordatachunkiterator.py @@ -44,8 +44,8 @@ def __init__( The upper bound on size in megabytes (MB) of the internal chunk for the HDF5 dataset. The chunk_shape will be set implicitly by this argument. Cannot be set if `chunk_shape` is also specified. - The default is 10MB. For more details, see - https://support.hdfgroup.org/HDF5/doc/TechNotes/TechNote-HDF5-ImprovingIOPerformanceCompressedDatasets.pdf + The default is 10MB, as recommended by the HDF5 group. + For more details, search the hdf5 documentation for "Improving IO Performance Compressed Datasets". chunk_shape : tuple, optional Manual specification of the internal chunk shape for the HDF5 dataset. Cannot be set if `chunk_mb` is also specified. diff --git a/src/neuroconv/tools/spikeinterface/spikeinterfacerecordingdatachunkiterator.py b/src/neuroconv/tools/spikeinterface/spikeinterfacerecordingdatachunkiterator.py index 95b14fc23..5d6407f19 100644 --- a/src/neuroconv/tools/spikeinterface/spikeinterfacerecordingdatachunkiterator.py +++ b/src/neuroconv/tools/spikeinterface/spikeinterfacerecordingdatachunkiterator.py @@ -48,8 +48,8 @@ def __init__( The upper bound on size in megabytes (MB) of the internal chunk for the HDF5 dataset. The chunk_shape will be set implicitly by this argument. Cannot be set if `chunk_shape` is also specified. - The default is 1MB, as recommended by the HDF5 group. For more details, see - https://support.hdfgroup.org/HDF5/doc/TechNotes/TechNote-HDF5-ImprovingIOPerformanceCompressedDatasets.pdf + The default is 10MB, as recommended by the HDF5 group. + For more details, search the hdf5 documentation for "Improving IO Performance Compressed Datasets". chunk_shape : tuple, optional Manual specification of the internal chunk shape for the HDF5 dataset. Cannot be set if `chunk_mb` is also specified.