regular timestamps calculated

[bendichter]

datta-lab-to-nwb/src/datta_lab_to_nwb/markowitz_gillis_nature_2023_keypoint/keypointinterface.py

Line 53 in 7540d94

timestamps = H5DataIO(np.arange(raw_keypoints.shape[0]) / SAMPLING_RATE, compression=True)

@pauladkisson why are we computing the timestamps here? Seems like we should be using starting time and sampling rate

[bendichter]

Also, more importantly, is this the first stream? I couldn't find any logic to synchronize this with other streams in the conversion code.

[pauladkisson]

Yes, this should be using starting time and sampling rate -- looks like a mistake made in all the confusion of temporal alignment.

We ended up adding the raw fiber photometry response data without temporal alignment, but with a comment warning that the raw data was not aligned. This is because the datta lab was unable to come up with the alignment information that we needed. All the other data streams (processed photometry, keypoints, moseq-extract output, etc.) are already aligned.

[bendichter]

ok got it, thanks!

[CodyCBakerPhD]

@pauladkisson did you want to regenerate the files with starting time + rate or just accept the less efficient timestamps and close the issue?

[pauladkisson]

I can go ahead and regenerate the files, it should be an easy fix.