If h5p js file is not found, it does not fail clearly

[matthewhilton]

The proxying method of our fork uses curl:

moodle-mod_hvp/proxy_pluginfile.php

Lines 74 to 76 in fd650e7

	// The proxy will pass content back from pluginfile.php
	$url = new moodle_url('/pluginfile.php/'.ltrim($relativepath, '/'));
	$curl->get($url->out());

However it is possible for the curl object to return something that is not a file. E.g. an error string:

https://github.com/moodle/moodle/blob/8fc1486d36ad7ed5f44deddd80bd6b19a8410e06/lib/filelib.php#L3934-L3940

Which results in the browser getting a HTTP 200 response, but no JS (since its just an error string) - this means you will get various errors about XYZ is not defined or cannot find constructor, since the JS didn't load properly.

But when you look in the browser console, the JS has a HTTP 200 status which is deceiving.