Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct flipped starting/ending balance column rename. #3979

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

zaneselvans
Copy link
Member

@zaneselvans zaneselvans commented Nov 30, 2024

Overview

  • Fixes the accidentally swapped starting/ending balance columns in the rename dictionary for the DBF derived pre-2021 FERC Form1 Schedule 278 data.

Originally fixed in #3969 by @yolandazzz13 -- I tried to separate that fix out on their branch to merge it in without the other Contributor serialization fixes which were integrated into catalyst-cooperative/pudl-archiver#486 but ran into permissions issues (or limitations in my understanding of how to work with other peoples' forks in a PR), and I wanted to get this merged in before I go on leave.

Closes #3592

Testing

  • Rematerialized the asset that these parameters apply to, as well as all upstream & downstream assets (there weren't any, other than the asset check)

@zaneselvans zaneselvans requested a review from pudlbot November 30, 2024 19:19
@zaneselvans zaneselvans added bug Things that are just plain broken. ferc1 Anything having to do with FERC Form 1 labels Nov 30, 2024
@zaneselvans zaneselvans self-assigned this Nov 30, 2024
@zaneselvans zaneselvans added this pull request to the merge queue Nov 30, 2024
Merged via the queue into main with commit 1d6096e Nov 30, 2024
17 checks passed
@zaneselvans zaneselvans deleted the 3592-ferc1-flipped-startend branch November 30, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that are just plain broken. ferc1 Anything having to do with FERC Form 1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Flipped starting/ending balance in out_ferc1_yearly_other_regulatory_liabilities_sched278
2 participants