Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate 2023 EIA 923 final release data #3903

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Integrate 2023 EIA 923 final release data #3903

merged 6 commits into from
Oct 15, 2024

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Oct 9, 2024

Overview

Closes #3902.

What problem does this address?

Integrates the final release of 2023 EIA 923 data, revised 2022 data and the September release of EIA 923 2024 monthly data.

What's changed in the data, and what have you changed?

2022 revision

The 2022 revision has the following changes:

  • aer_fuel_type_code changed to mer_fuel_type_code in the data. As discussed in Integrate EIA 923 ER #3721, the aer and mer fuel type codes are equivalent, so this is mapped to the same column.
  • the petcoke_stocks tab is removed

2023 final release

  • One plant with EIA ID 6251 (South Texas Nuclear) has a huge spike in cooling water usage in April 2023, which explains the failure in the cooling water continuity. I'm bumping the outliers by 1, rather than adjusting the thresholds.

Data Integration Tasks

To-do list

Documentation

Make sure to update relevant aspects of the documentation.

Tasks

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

@e-belfer e-belfer added eia923 Anything having to do with EIA Form 923 new-data Requests for integration of new data. labels Oct 9, 2024
@e-belfer e-belfer self-assigned this Oct 9, 2024
@e-belfer e-belfer requested a review from aesharpe October 10, 2024 12:19
@e-belfer e-belfer marked this pull request as ready for review October 10, 2024 12:19
Copy link
Member

@aesharpe aesharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some high-level Qs

@aesharpe aesharpe added data-update When fresh data is integrated into PUDL from quarterly or annual updates and removed new-data Requests for integration of new data. labels Oct 11, 2024
@e-belfer e-belfer requested a review from aesharpe October 11, 2024 13:30
@e-belfer e-belfer requested a review from aesharpe October 15, 2024 12:44
@aesharpe aesharpe added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit f0247ea Oct 15, 2024
19 checks passed
@aesharpe aesharpe deleted the 2023-eia923-fr branch October 15, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-update When fresh data is integrated into PUDL from quarterly or annual updates eia923 Anything having to do with EIA Form 923
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Integrate EIA 923 2023 final release data
2 participants