-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate 2023 EIA 923 final release data #3903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-belfer
added
eia923
Anything having to do with EIA Form 923
new-data
Requests for integration of new data.
labels
Oct 9, 2024
aesharpe
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some high-level Qs
src/pudl/package_data/eia923/column_maps/byproduct_expenses_and_revenues.csv
Show resolved
Hide resolved
aesharpe
added
data-update
When fresh data is integrated into PUDL from quarterly or annual updates
and removed
new-data
Requests for integration of new data.
labels
Oct 11, 2024
aesharpe
reviewed
Oct 11, 2024
aesharpe
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
data-update
When fresh data is integrated into PUDL from quarterly or annual updates
eia923
Anything having to do with EIA Form 923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #3902.
What problem does this address?
Integrates the final release of 2023 EIA 923 data, revised 2022 data and the September release of EIA 923 2024 monthly data.
What's changed in the data, and what have you changed?
2022 revision
The 2022 revision has the following changes:
aer_fuel_type_code
changed tomer_fuel_type_code
in the data. As discussed in Integrate EIA 923 ER #3721, theaer
andmer
fuel type codes are equivalent, so this is mapped to the same column.petcoke_stocks
tab is removed2023 final release
Data Integration Tasks
To-do list
Documentation
Make sure to update relevant aspects of the documentation.
Tasks
Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list