Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform XBRL core_ferc714__yearly_planning_area_demand_forecast table #3856

Merged
merged 10 commits into from
Sep 23, 2024

Conversation

aesharpe
Copy link
Member

@aesharpe aesharpe commented Sep 19, 2024

Overview

Closes #3837 .

What problem does this address?

Adds XBRL data (2021 +) for the annual demand forecast table.

What did you change?

  • Add a YearlyPlanningAreaDemandForecast class and class functions.
  • Migrate CSV transforms into these class functions.
  • Add forecast to the column names with forecasted values.

Ideas

We could add some tests for the 714 data that made sure the mwh and mw values fell within a reasonable range. Might be something we put on the backburner for now.

Testing

How did you make sure this worked? How can a reviewer verify this?

Materialize the core_ferc714__yearly_planning_area_demand_forecast table in dagster.

To-do list

…ferc714__yearly_planning_area_demand_forecast table
Copy link
Member Author

@aesharpe aesharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a high-level comment, but I spent some time tackling the duplicate PK values in the XBRL data before I realized that they were getting handled in the FercXBRLSQLiteIOManager class load_input function. Specifically, I didn't realize that the older publication_date values were getting dropped and the report_year column was getting made there. It's a little confusing to have that happen in the IOManager vs. the transforms. I understand that it might be more efficient to do it that way though.

Out of scope to change for this PR, just a thought I had.

src/pudl/transform/ferc714.py Show resolved Hide resolved
@aesharpe aesharpe requested a review from cmgosnell September 19, 2024 08:07
@aesharpe aesharpe self-assigned this Sep 19, 2024
@aesharpe aesharpe added ferc714 Anything having to do with FERC Form 714 data-update When fresh data is integrated into PUDL from quarterly or annual updates labels Sep 19, 2024
@aesharpe aesharpe marked this pull request as ready for review September 20, 2024 16:05
Copy link
Member

@cmgosnell cmgosnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks grand!! i have two real but minor questions and one nittiest of nit.

src/pudl/metadata/fields.py Show resolved Hide resolved
src/pudl/transform/ferc714.py Outdated Show resolved Hide resolved
src/pudl/transform/ferc714.py Outdated Show resolved Hide resolved
src/pudl/transform/ferc714.py Outdated Show resolved Hide resolved
src/pudl/transform/ferc714.py Outdated Show resolved Hide resolved
Copy link
Member

@cmgosnell cmgosnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cmgosnell
Copy link
Member

oh! @aesharpe ! can you add the new years of data into the Ferc714CheckSpec asset check?

@aesharpe aesharpe merged commit 5cb6492 into transform-714-xbrl Sep 23, 2024
17 checks passed
@aesharpe aesharpe deleted the transform-714-yearly-forecast branch September 23, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-update When fresh data is integrated into PUDL from quarterly or annual updates ferc714 Anything having to do with FERC Form 714
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Write transform function to clean and normalize FERC 714 XBRL annual 10-year load forecast table
2 participants