-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename EIA denorm assets #2858
Rename EIA denorm assets #2858
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rename-core-assets #2858 +/- ##
==================================================
Coverage 88.5% 88.5%
==================================================
Files 90 90
Lines 10139 10139
==================================================
Hits 8982 8982
Misses 1157 1157
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking: One strategy to avoid resolving migration conflicts when we start to merge these all into the core
branch is to actually rebase this on your FERC PR and have the migrations build on one another.
Non-blocking: The python-output-table-conversion-debug
looks like it's missing updated names. If we want to do a separate notebook cleanup PR at the end of our various renames that makes sense to me, though.
Otherwise I was able to run the fast ETL and build the docs successfully.
PR Overview
This PR applies the naming conventions from #2517 to the denormalized EIA assets. It does not resolve the duplicate EIA aggregation issue #2857.
PR Checklist
dev
).