Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename EIA denorm assets #2858

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Conversation

bendnorman
Copy link
Member

@bendnorman bendnorman commented Sep 15, 2023

PR Overview

This PR applies the naming conventions from #2517 to the denormalized EIA assets. It does not resolve the duplicate EIA aggregation issue #2857.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 100.0% and no project coverage change.

Comparison is base (0a912e4) 88.5% compared to head (a2042de) 88.5%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           rename-core-assets   #2858   +/-   ##
==================================================
  Coverage                88.5%   88.5%           
==================================================
  Files                      90      90           
  Lines                   10139   10139           
==================================================
  Hits                     8982    8982           
  Misses                   1157    1157           
Files Changed Coverage Δ
src/pudl/analysis/allocate_gen_fuel.py 91.3% <ø> (ø)
src/pudl/analysis/mcoe.py 97.4% <ø> (ø)
src/pudl/analysis/service_territory.py 52.1% <ø> (ø)
src/pudl/metadata/resources/eia.py 100.0% <ø> (ø)
src/pudl/metadata/resources/eia860.py 100.0% <ø> (ø)
src/pudl/metadata/resources/eia923.py 100.0% <ø> (ø)
src/pudl/output/ferc714.py 96.2% <ø> (ø)
src/pudl/output/eia.py 59.0% <100.0%> (ø)
src/pudl/output/eia860.py 100.0% <100.0%> (ø)
src/pudl/output/eia923.py 97.7% <100.0%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e-belfer e-belfer self-requested a review September 18, 2023 14:43
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: One strategy to avoid resolving migration conflicts when we start to merge these all into the core branch is to actually rebase this on your FERC PR and have the migrations build on one another.

Non-blocking: The python-output-table-conversion-debug looks like it's missing updated names. If we want to do a separate notebook cleanup PR at the end of our various renames that makes sense to me, though.

Otherwise I was able to run the fast ETL and build the docs successfully.

@bendnorman bendnorman merged commit 8b468db into rename-core-assets Sep 19, 2023
9 checks passed
@bendnorman bendnorman deleted the rename-eia-output-assets branch September 19, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants