Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing keywords in archived datasources #2851

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Sep 11, 2023

Addresses #2850 and issue #80 in the pudl-archiver repo. The lack of keywords is a blocking issue for PHMSA data extraction using the pudl Datastore, so this iceboxed issue is now a priority again. While I'm at it, I may as well fix all the other datasets that are missing keywords / have inadequate ones.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@e-belfer e-belfer changed the base branch from main to dev September 11, 2023 16:42
@e-belfer e-belfer linked an issue Sep 11, 2023 that may be closed by this pull request
4 tasks
@e-belfer e-belfer self-assigned this Sep 11, 2023
@e-belfer e-belfer added the metadata Anything having to do with the content, formatting, or storage of metadata. Mostly datapackages. label Sep 11, 2023
@e-belfer e-belfer marked this pull request as ready for review September 11, 2023 16:49
Copy link
Member

@zaneselvans zaneselvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up and filling in the gaps!

It looked like you did another PR to assert that these fields are filled in when we create archives too which is great.

I suggested a few additional keywords if you feel like adding them.

src/pudl/metadata/constants.py Show resolved Hide resolved
src/pudl/metadata/constants.py Show resolved Hide resolved
src/pudl/metadata/constants.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (73a0c79) 88.5% compared to head (b12967a) 88.5%.
Report is 3 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2851   +/-   ##
=====================================
  Coverage   88.5%   88.5%           
=====================================
  Files         90      90           
  Lines      10139   10139           
=====================================
  Hits        8982    8982           
  Misses      1157    1157           
Files Changed Coverage Δ
src/pudl/metadata/constants.py 100.0% <ø> (ø)
src/pudl/metadata/sources.py 100.0% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e-belfer e-belfer merged commit 46650dd into dev Sep 12, 2023
9 checks passed
@e-belfer e-belfer deleted the add_datasource_keywords branch September 12, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata Anything having to do with the content, formatting, or storage of metadata. Mostly datapackages.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add keywords to Zenodo archive to fix dataset validation issue
2 participants