Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator to the retirement_year / _month columns for the monthly… #2835

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

aesharpe
Copy link
Member

@aesharpe aesharpe commented Sep 6, 2023

From issue #2834

The monthly data retirement dates were getting mapped to retirement_year and retirement_month instead of generator_retirement_year and generator_retirement_month in the mapping spreadsheets. Only the generator_retirement_ column is included in the metadata for the cleaned version of the generators_eia860 so all the values for retirement date from the monthly data were getting dropped.

I updated the spreadsheet to map to generator_retirement_year and generator_retirement_month which should fix the problem.

… data so it matches the annual data and doesn't get nulled out
@aesharpe aesharpe added bug Things that are just plain broken. eia860 Anything having to do with EIA Form 860 labels Sep 6, 2023
@aesharpe aesharpe requested a review from zaneselvans September 6, 2023 21:22
@aesharpe aesharpe self-assigned this Sep 6, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aesharpe aesharpe marked this pull request as ready for review September 6, 2023 21:24
@aesharpe aesharpe linked an issue Sep 6, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d543d4b) 88.5% compared to head (532b36a) 88.5%.
Report is 11 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2835   +/-   ##
=====================================
  Coverage   88.5%   88.5%           
=====================================
  Files         90      90           
  Lines      10150   10150           
=====================================
  Hits        8989    8989           
  Misses      1161    1161           
Files Changed Coverage Δ
src/pudl/metadata/dfs.py 100.0% <ø> (ø)
src/pudl/metadata/resources/ferc1.py 100.0% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zaneselvans zaneselvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye, glad it was a simple fix.

I feel like this should have raised a warning or an error somewhere in the extract step due to mismatched column names.

@zaneselvans
Copy link
Member

I'm going to go ahead and merge this so it can be part of the builds tonight.

@zaneselvans zaneselvans merged commit 19d3343 into dev Sep 6, 2023
8 checks passed
@zaneselvans zaneselvans deleted the fix-860m-retirement-bug branch September 6, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that are just plain broken. eia860 Anything having to do with EIA Form 860
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Missing retirement dates from 860m data
2 participants