-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make leafy balance sheet assets & liabilities data #2805
Merged
Merged
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
a959df6
fix twiddly overlapping almost stepparents
cmgosnell d649d4f
deal with deterministic shit omigoshhhh
cmgosnell 2e8e3f7
remove one loose total w/ different dims in children
cmgosnell e78915a
Selectively remove calculations that specify conflicting weights.
zaneselvans 9cb516c
select on the mask before dropping instead of dropping the full masks…
cmgosnell f3b1622
lol remove a very chatty log
cmgosnell cd74c24
Simplify dropping of duplicate weights
zaneselvans 67e7caa
Check we aren't dropping nodes with weight = -1
zaneselvans 43f8857
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans f5b53ab
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans 46b0997
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans 7640af7
Check that multi-valued weights have expected frequency.
zaneselvans e11ef21
Add sanity checks for conflicting weights.
zaneselvans 3e09106
add ability to add specific dimensions into tags
cmgosnell c2d2102
Merge branch 'explode_tree_fixes' into explode_tag_dimensions
cmgosnell 47f323e
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans 0b1fe1d
Merge branch 'explode_tree_fixes' into explode_tag_dimensions
cmgosnell b78e69a
Defer reporting duplicated notes until after pruning
zaneselvans 11533d9
Merge branch 'explode_tree_fixes' into explode_tag_dimensions
zaneselvans 68cf7f4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f2a06dc
Merge pull request #2817 from catalyst-cooperative/explode_tag_dimens…
zaneselvans e523d3a
draft version of making the forest as a table
cmgosnell 1f1f8eb
Merge branch 'explode_tag_dimensions' into explode_forest_as_table
cmgosnell d829570
lil clean up reorg fun times
cmgosnell 81dafb9
Set error tolerances such that CI can pass.
zaneselvans 17b2022
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans cb63e55
Merge branch 'explode_tree_fixes' into explode_forest_as_table
zaneselvans 08b87b1
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans a352046
Merge branch 'explode_tree_fixes' into explode_forest_as_table
zaneselvans 3b6217b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d9d1cb1
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans 8f81e9c
Merge branch 'explode_tree_fixes' into explode_forest_as_table
zaneselvans f176a84
Refactor XbrlCalculationForestFerc1.forest_as_table() to be recursive.
zaneselvans af6b6d0
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans 042d852
Merge branch 'explode_tree_fixes' into explode_forest_as_table
zaneselvans 16307e0
Update to steup-micromamba and checkout@v4 actions
zaneselvans 2ae4ae3
Update to steup-micromamba and checkout@v4 actions
zaneselvans 1a2e444
Use pathlib.Path for ogr2ogr
zaneselvans 4cab17f
Merge pull request #2832 from catalyst-cooperative/explode_forest_as_…
zaneselvans 7b51b3e
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans 19d172e
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans f728ff1
Add checks for nodes with conflicting tags or lost tagged nodes.
zaneselvans 05d45f7
Flesh out docstrings for annotated_forest and node check functions.
zaneselvans 08e0ff4
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans e29492f
Use pd.isna() to identify NA explosion tags and replace with empty dict
zaneselvans 2c8c1f5
Consolidate calculation tolerances into a data class.
zaneselvans 26f3491
Add columns to exploded metadata for debugging and readability purposes
zaneselvans 56e0c7f
Flesh out docstring for prune_unrooted()
zaneselvans e5157d4
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans 16a7204
Minor readability / typo fixes
zaneselvans 56eabf5
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans d018a5d
Merge branch 'dev' into explode_tree_fixes
zaneselvans a9ddaa0
Model calculation weights as edge attributes.
zaneselvans b153c2a
Remove 'passthrough' node infrastructure.
zaneselvans a88e620
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans 5751827
Drop DBF metadata columns when aligning row numbers since we don't ne…
zaneselvans 62ef211
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans 884dfac
Merge branch 'relax-libabseil' into explode_tree_fixes
zaneselvans 6df7967
Merge branch 'explode_ferc1' into explode_tree_fixes
zaneselvans 421bada
Consolidate MetadataExploder properties into (Data)Exploder class.
zaneselvans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works fine and i think is a good solution for now, but i think the more holistic way to do this would be to get all of the nodes direct predecessor nodes in order to generate both the parent_cols and calc_cols in order to select the individual records to select on within
exploded_calcs
during the merge inset_forest_attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should talk about this. I'm not sure I understand what you're saying. I agree this probably belongs over in
set_forest_attributes()
or maybe it its owndeduplicate_calcs()
method that's called byset_forest_attributes()