Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A fancier way of dealing with mixed Zenodo DOIs. #2799

Closed
wants to merge 1 commit into from

Conversation

zaneselvans
Copy link
Member

PR Overview

I tried creating a ZenodoDOI class that knows how to manage both sandbox and production archives. It works fine, but in the end seemed like it had too many little tentacles that touched other things in other places. But maybe there's a way to make it feel cleaner and simpler?

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@zaneselvans zaneselvans requested a review from rousik August 20, 2023 16:08
@zaneselvans
Copy link
Member Author

I think I'll close this for now in favor of the more limited changes made in #2798

@zaneselvans zaneselvans deleted the zenodo-doi branch September 12, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant