Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map unmapped FERC XBRL IDs #2883

Closed
Tracked by #2811
e-belfer opened this issue Sep 21, 2023 · 2 comments
Closed
Tracked by #2811

Map unmapped FERC XBRL IDs #2883

e-belfer opened this issue Sep 21, 2023 · 2 comments
Assignees

Comments

@e-belfer
Copy link
Member

No description provided.

@jdangerx
Copy link
Member

This was done on the 2811-ferc1-2022 branch - diff below:

diff --git a/src/pudl/package_data/glue/utility_id_ferc1.csv b/src/pudl/package_data/glue/utility_id_ferc1.csv
index cde4d3f71..a0623757c 100644
--- a/src/pudl/package_data/glue/utility_id_ferc1.csv
+++ b/src/pudl/package_data/glue/utility_id_ferc1.csv
@@ -151,7 +151,7 @@ utility_id_ferc1,utility_id_ferc1_xbrl,utility_id_ferc1_dbf
 150,,1001
 151,,1003
 152,C000029,231
-153,C000030,447
+153,C000030,255
 154,C000038,250
 155,C000041,161
 156,C000045,294
@@ -402,7 +402,7 @@ utility_id_ferc1,utility_id_ferc1_xbrl,utility_id_ferc1_dbf
 408,R001052,52
 409,R001072,72
 411,R001087,87
-414,R001140,140
+414,C011644,140
 419,R001268,268
 420,R001298,298
 421,R001301,301
@@ -412,10 +412,12 @@ utility_id_ferc1,utility_id_ferc1_xbrl,utility_id_ferc1_dbf
 428,R001419,419
 429,R001422,422
 436,R001445,445
-437,,255
 439,R001515,515
 440,R001520,520
 441,R001521,521
 442,,278
 443,C010845,
 444,C011304,
+445,C011745,447
+446,C004679,
+447,C011785,
\ No newline at end of file
diff --git a/src/pudl/package_data/glue/utility_id_pudl.csv b/src/pudl/package_data/glue/utility_id_pudl.csv
index 809172cc1..721392c2c 100644
--- a/src/pudl/package_data/glue/utility_id_pudl.csv
+++ b/src/pudl/package_data/glue/utility_id_pudl.csv
@@ -256,7 +256,7 @@ utility_id_pudl,utility_id_ferc1,utility_name_ferc1,utility_id_eia,utility_name_
 258,111,Pinnacle West Marketing & Trading Co. LLC,,
 259,414,Pioneer Power and Light Company,,
 260,153,"PJM Interconnection, LLC",,
-261,437,"PJM Settlement, Inc.",,
+261,445,"PJM Settlement, Inc.",,
 262,84,Platte-Clay Electric Cooperative Inc.,,
 263,250,Portland General Electric Company,15248,Portland General Electric Co
 264,290,Potomac Electric Power Company,,
@@ -14600,3 +14600,5 @@ utility_id_pudl,utility_id_ferc1,utility_name_ferc1,utility_id_eia,utility_name_
 14642,,,65731,"ESA Albemarle NC Solar, LLC"
 14643,,,65663,KDC Solar CV Cedar Lane Park LLC
 14644,,,65673,"Blackwell Test Facility, LLC"
+14645,446,"Transource Oklahoma, LLC",,
+14646,447,"Mountrail-Williams Electric Cooperative",,
\ No newline at end of file

There were no new plants identified in pytest test/integration/glue_test.py --save-unmapped-ids --live-dbs, so it seems like I didn't need to add anything to pudl_id_mapping.xlsx. @aesharpe does that sound correct?

@e-belfer
Copy link
Member Author

Marked as done but not closed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants