Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers: You have headers that are out of order. #494

Open
sm2x opened this issue Apr 25, 2021 · 3 comments
Open

Headers: You have headers that are out of order. #494

sm2x opened this issue Apr 25, 2021 · 3 comments
Assignees

Comments

@sm2x
Copy link

sm2x commented Apr 25, 2021

castle.cms 2.6.31

The above "headers error" persists although all the pages are OK, even on a "newly created theme".

image

@DavidHenne
Copy link
Contributor

Unable to reproduce an error here. This quality check should fail under two circumstances:

  1. headers being out of numerical order (ex. an h3 appearing anywhere higher on the page than an h2)
  2. headers skipping a level (ex. an h2 immediately followed by an h4 with no h3 in between them)

Both of these conditions must be met for it to pass.

@sm2x
Copy link
Author

sm2x commented Apr 27, 2021

I have not done anything yet, by default, I mean from a fresh installation (castle.cms 2.6.31) using the default theme (Castle) it is already showing the Headers check error.

@DavidHenne
Copy link
Contributor

Are you talking about on the default Castle welcome page? If you inspect the page elements, you'll notice it has some out of order headers like I mentioned in point 1 above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants