JOSS #45
Merged
JOSS #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 81.57% 81.57%
=======================================
Files 6 6
Lines 2008 2008
=======================================
Hits 1638 1638
Misses 370 370 ☔ View full report in Codecov by Sentry. |
castelao
force-pushed
the
joss
branch
2 times, most recently
from
e650159
to
cea16fa
Compare
|
A note to myself. I forgot to cite the GSW-Fortran! |
It seems like it was the only implementation with a doi missing. It might be worth figure out how to cite the other implementation, even if those other ones don't have a doi or any proper citation descriptor.
Type techreport might be more adequate. Other minor fixes.
Thanks to @efiring.
@efiring, thanks for the note. Is it bette now? The point behind is that with `features='compat'` we guarantee compatibility with GSW-m. While GSW-C has some minor differences.
Somehow JOSS processing assumes that a bib reference type manual should be from a software and adds '[Computer software]' to the refence. Let's see if a techreport resolves that.
Playing with bib file.
Back to pages 1--28 instead of 28pp
It's up to JOSS references style to decide showing it or not.
Perfect! Clear message. Thanks @efiring!
For the software without DOI, reference type 'manual' might be better than 'article'.
castelao
force-pushed
the
joss
branch
2 times, most recently
from
a121331
to
374c34d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft