-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy changes are changing ids on ctitest #524
Comments
This seems to be working now. However, changing privacy of frameworks on ctitest can cause the editor to freeze, especially with big frameworks. |
Optimization of this will occur with Eduworks/ec#22 |
Just to check, are we using the asynchronous modes of functions to do encryption? They are much much much faster. |
I have the synchronous versions in there now, I'll look into using the Ec async helper to speed this up. |
Now uses async methods, should be much faster than before. Some changes are still needed to make sure the concept scheme displays the correct concepts in the lefthand pane without duplicating any, but there are other issues open for that. The actual encryption/decryption appears to be working. |
This seems to be occurring where there are special symbols - in the case of the 68W framework I linked several competencies and had no trouble making my new framework private. When I linked a competency with a TM symbol though, all the competencies disappeared from the left panel and I got the same console errors Eddie posted above. We'll need to look into how these symbols are encrypted/decrypted. |
@eddavies I created a new issue for that since it's probably going to involve some bigger changes. Can you do some privacy testing on data that doesn't have any symbols and let me know if you find any other issues? |
Don't seem to be finding any. Will open a new issue if some are found. |
Fixes for special symbols are on their way. |
Displayed id becomes https://sandbox.credentialengineregistry.org/resources and ctid: resources. Ctid appears to be correct in the console, and id is something like https://sandbox.credentialengineregistry.org/resources/1552933010416
The text was updated successfully, but these errors were encountered: