Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy changes are changing ids on ctitest #524

Closed
woodkri opened this issue Mar 18, 2019 · 10 comments
Closed

Privacy changes are changing ids on ctitest #524

woodkri opened this issue Mar 18, 2019 · 10 comments

Comments

@woodkri
Copy link
Member

woodkri commented Mar 18, 2019

Displayed id becomes https://sandbox.credentialengineregistry.org/resources and ctid: resources. Ctid appears to be correct in the console, and id is something like https://sandbox.credentialengineregistry.org/resources/1552933010416

@eddavies
Copy link

This seems to be working now. However, changing privacy of frameworks on ctitest can cause the editor to freeze, especially with big frameworks.

@eddavies eddavies assigned woodkri and unassigned eddavies Mar 21, 2019
@Lomilar
Copy link
Member

Lomilar commented Mar 22, 2019

Optimization of this will occur with Eduworks/ec#22

@Lomilar
Copy link
Member

Lomilar commented Mar 22, 2019

Just to check, are we using the asynchronous modes of functions to do encryption? They are much much much faster.

@woodkri
Copy link
Member Author

woodkri commented Mar 22, 2019

I have the synchronous versions in there now, I'll look into using the Ec async helper to speed this up.

@woodkri
Copy link
Member Author

woodkri commented Apr 2, 2019

Now uses async methods, should be much faster than before. Some changes are still needed to make sure the concept scheme displays the correct concepts in the lefthand pane without duplicating any, but there are other issues open for that. The actual encryption/decryption appears to be working.

@woodkri woodkri assigned eddavies and unassigned woodkri Apr 2, 2019
@eddavies
Copy link

eddavies commented Apr 8, 2019

The duplication is no longer occurring but running into an error where competencies are disappearing. Below is a screenshot of where I created a new framework then copied over 160 competencies from an existing framework then attempted to make the framework private:

added private

Additional console errors:

console of private

@eddavies eddavies assigned woodkri and unassigned eddavies Apr 8, 2019
@woodkri
Copy link
Member Author

woodkri commented Apr 8, 2019

This seems to be occurring where there are special symbols - in the case of the 68W framework I linked several competencies and had no trouble making my new framework private. When I linked a competency with a TM symbol though, all the competencies disappeared from the left panel and I got the same console errors Eddie posted above. We'll need to look into how these symbols are encrypted/decrypted.

@woodkri
Copy link
Member Author

woodkri commented Apr 8, 2019

@eddavies I created a new issue for that since it's probably going to involve some bigger changes. Can you do some privacy testing on data that doesn't have any symbols and let me know if you find any other issues?

@woodkri woodkri assigned eddavies and unassigned woodkri Apr 8, 2019
@eddavies
Copy link

eddavies commented Apr 8, 2019

Don't seem to be finding any. Will open a new issue if some are found.

@Lomilar
Copy link
Member

Lomilar commented May 24, 2019

Fixes for special symbols are on their way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants