Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final pass on contract self payment #4685

Open
SaiProServ opened this issue Apr 30, 2024 · 2 comments
Open

Final pass on contract self payment #4685

SaiProServ opened this issue Apr 30, 2024 · 2 comments
Assignees
Labels
rc-5 Release Candidate 5

Comments

@SaiProServ
Copy link

In feat-2.0 we’re adding functionality that allows contracts to pay for themselves (see operations.rs, execute_finalized_block()). Once this functionality is ready we need to test that it’s working correctly by writing new reactor tests that validate this functionality. So far all payment related tests have been grouped in the node/src/reactor/main_reactor/tests/transactions.rs file. Write a few more test cases for the contract paying for itself functionality.

@devendran-m devendran-m added the rc-5 Release Candidate 5 label Sep 9, 2024
@devendran-m devendran-m changed the title Write reactor payment tests for contracts that pay for themselves Final pass on contract self payment Sep 13, 2024
@EdHastingsCasperAssociation
Copy link
Collaborator

blocked by #4897

@EdHastingsCasperAssociation
Copy link
Collaborator

As discussed there is a PR up on the blocking issue, so in the interests of time even tho the PR is still in review I will code this against that PR. This may result in some rework but probably not and its less worse than losing more days waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rc-5 Release Candidate 5
Projects
None yet
Development

No branches or pull requests

3 participants