Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 dropping istio for now #59

Merged
merged 1 commit into from
Nov 19, 2024
Merged

🔧 dropping istio for now #59

merged 1 commit into from
Nov 19, 2024

Conversation

mfreeman451
Copy link
Contributor

@mfreeman451 mfreeman451 commented Nov 19, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced API structure with new /api prefix for user-related operations.
    • Introduced support for OpenID Connect (OIDC) and OAuth2 features in the Hydra service configuration.
    • Updated mutator configuration in Oathkeeper to handle tenant identification.
  • Bug Fixes

    • Fixed database connection settings for a production-like environment.
  • Documentation

    • Updated logging configuration for structured logging in Kratos.
  • Chores

    • Updated container image version for the eventrunner API.
    • Removed deprecated authorization policy for Oathkeeper service.

Copy link

coderabbitai bot commented Nov 19, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes several significant changes across multiple files. The MongoDB connection URI has been updated to reflect a Kubernetes service address, and API endpoint paths have been modified to include a versioning prefix. Additionally, the eventrunner-api Deployment configuration has been updated to a new image version. New configuration sections for OIDC and OAuth2 have been added to the Hydra service. An Istio authorization policy has been removed, while a new IstioOperator configuration has been introduced. Various updates to Kratos and Oathkeeper configurations enhance identity management and authentication mechanisms.

Changes

File Path Change Summary
cmd/api/main.go Updated MongoDB URI to Kubernetes service address; modified API endpoint paths to include /api; commented out OAuth.
k8s/eventrunner/base/eventrunner.yaml Updated container image version from v0.0.04 to v0.0.11.
k8s/hydra/values.yaml Added oidc and oauth2 sections; included fields for subject identifiers and token claims; switched dsn to env var.
k8s/istio/authorization.yaml Removed AuthorizationPolicy for eventrunner-oathkeeper.
k8s/istio/istio-operator.yaml Introduced new IstioOperator configuration for Istio control plane with external authorization provider settings.
k8s/kratos/kratos-values.yaml Updated user identity schema; enhanced logging configuration; added resources field in automigration; ingress disabled.
k8s/oathkeeper/01-meshconfig.yaml Renamed extension provider from "oathkeeper-ext-authz" to "ext-authz".
k8s/oathkeeper/02-auth-policy.yaml Renamed provider field from oathkeeper-ext-authz to ext-authz.
k8s/oathkeeper/values.yaml Updated mutators and authenticators sections to enhance tenant identification and scope strategy.

Possibly related PRs

  • Updates/use gofr oauth #37: Updates to the Ory Oathkeeper configuration, relevant to OAuth functionality and API access rules.
  • 🔧 WIP ory crap #39: Modifications to the authentication server's ConfigMap, potentially interacting with user-related API changes.
  • Updates/use gofr oauth #40: Updates to Oathkeeper rules, relevant to API authentication and authorization processes.
  • 🔧 sync #41: Further modifications to Oathkeeper rules, crucial for API security and access control.
  • 🔧 sync #42: Updates to authentication server rules, relevant to API modifications in user management.
  • 🔧 WIP ory crap still #43: Modifications to Oathkeeper rules, essential for API authentication processes.
  • sync #44: Updates to Oathkeeper configuration rules, directly related to API changes in user access.
  • 🔧 sync for 1filellm #45: Changes to the API gateway's rules, relevant to authentication and authorization mechanisms.
  • Refactor/istio ory #51: Introduces changes to Oathkeeper configuration, aligning with API authentication and authorization processes.

🐰 In the meadow where changes bloom,
A new path for users makes room.
With Mongo's address now set to the sky,
APIs flourish, oh my, oh my!
OAuth takes a nap, while Hydra sings,
In this world of code, joyfully springs! 🌼

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint

level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: cannot load module ../gofr listed in go.work file: open ../gofr/go.mod: no such file or directory\n"


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mfreeman451 mfreeman451 merged commit 5e62ee9 into main Nov 19, 2024
1 of 4 checks passed
@mfreeman451 mfreeman451 deleted the refactor/istio_ory branch November 19, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant