Refactor/istio ory

[mfreeman451]

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced TLS configuration for ingress with wildcard subdomain support.
  • Updated access rules and scope strategy for Oathkeeper.

• Bug Fixes

  • Corrected variable typo in Kratos self-service methods.

• Configuration Updates

  • Modified service ports for eventrunner-api.
  • Updated backend service references and timeout formats in Istio configurations.
  • Introduced new fields in Certificate resource for auth services.

These updates improve service accessibility, security configurations, and operational visibility across the platform.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several modifications across multiple Kubernetes configuration files related to the eventrunner-api, hydra, kratos, and oathkeeper. Key changes include the removal of specific annotations from the Ingress resource, updates to the AuthorizationPolicy provider name, and alterations to the istio-mesh-config for the external authorization provider. Additionally, the service port for eventrunner-api is changed, and the ingress configurations for hydra and kratos are updated to allow wildcard subdomain matching. The oathkeeper configuration also sees updates to access rules and authentication strategies.

Changes

File Path	Change Summary
k8s/eventrunner-api/base/ingress.yaml	Removed annotations: service-upstream, upstream-vhost. Updated backend service configuration.
k8s/eventrunner-api/base/istio-auth-policy.yaml	Updated provider name from oathkeeper-ext-authz to ext-authz.
k8s/eventrunner-api/base/istio-mesh-config.yaml	Updated ext-authz service from oathkeeper-proxy to oathkeeper-api, port changed from 4455 to 4456, and simplified timeout. Removed several fields and added new ones like failOpen and statusOnError.
k8s/eventrunner-api/base/service.yaml	Changed service port from 8200 to 80.
k8s/hydra/values.yaml	Updated ingress host entry from hydra.tunnel.threadr.ai to *.tunnel.threadr.ai.
k8s/kratos/kratos-values.yaml	Updated ingress host entry from kratos.tunnel.threadr.ai to *.tunnel.threadr.ai, corrected client_secret typo, changed log level and format, enabled automigration, and standardized secret management.
k8s/oathkeeper/values.yaml	Updated access rules and scope_strategy for the JWT authenticator.
k8s/tls/auth.yaml	Added labels and usages fields to Certificate resource.

Possibly related PRs

• 🔧 WIP ory crap #39: Modifications to the oathkeeper-rules-data ConfigMap, including updates to the upstream URL related to the eventrunner-api.
• Updates/use gofr oauth #40: Updates to the oathkeeper-rules ConfigMap, including changes to the upstream URL for the eventrunner-api.
• 🔧 sync #41: Changes to rule identifiers and upstream URLs in the oathkeeper-rules-data ConfigMap relevant to the eventrunner-api.
• sync #44: Modifications to the oathkeeper-rules-data ConfigMap, including updates to the decisions endpoint.
• 🔧 sync for 1filellm #45: Updates to the oathkeeper-rules-data ConfigMap, including renaming rule IDs and modifying upstream URLs related to the eventrunner-api.

🐇 In the fields where we hop and play,
Changes bloom like flowers in May.
Annotations gone, new paths to find,
With wildcards dancing, oh so kind!
Oathkeeper's rules take a leap,
In the garden of code, our secrets we keep! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.