Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secretgen-controller should allow configuration of the metrics server port #509

Closed
douglas-c opened this issue Dec 6, 2023 · 0 comments · Fixed by #510
Closed

secretgen-controller should allow configuration of the metrics server port #509

douglas-c opened this issue Dec 6, 2023 · 0 comments · Fixed by #510
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request

Comments

@douglas-c
Copy link

Describe the problem/challenge you have
Running secretgen-controller in a deployment with hostNetwork=true can lead to the default metrics server port 8080 conflicting with other applications running on that node.

Describe the solution you'd like
We would like the metrics server port to be configurable, at least via container args if not through something more formal like a ConfigMap.

Anything else you would like to add
There was an identical issue with kapp-controller, see kapp-controller/issues/394 which was fixed with kapp-controller/pull/404. A similar fix would work for our use case as well.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you would like to work on this issue.

@douglas-c douglas-c added carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Dec 6, 2023
@renuy renuy added carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage This issue has not yet been reviewed for validity labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants