Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log version in node startup #8

Closed
7 tasks done
gligneul opened this issue Jun 7, 2023 · 2 comments · Fixed by #86
Closed
7 tasks done

Log version in node startup #8

gligneul opened this issue Jun 7, 2023 · 2 comments · Fixed by #86
Assignees
Milestone

Comments

@gligneul
Copy link
Contributor

gligneul commented Jun 7, 2023

📚 Context

Given the log, we want to know which version of the node is running. This is particularly useful when someone sends us a log with a problem.

✔️ Solution

This could be done with the help of the following built crate.

📈 Subtasks

Apply the modifications to all services:

  • state server
  • dispatcher
  • autority-claimer
  • advance runner
  • inspect server
  • graphql server
  • host runner
@gligneul gligneul added this to the 1.1.0 milestone Jun 7, 2023
@gligneul gligneul removed this from the 1.1.0 milestone Jul 13, 2023
@gligneul gligneul transferred this issue from cartesi/rollups Jul 27, 2023
@fmoura fmoura moved this from 📋 Backlog to 🏗 In progress in Node Unit Aug 18, 2023
@fmoura fmoura self-assigned this Aug 18, 2023
@fmoura fmoura added this to the 1.1.0 milestone Aug 18, 2023
@fmoura
Copy link
Contributor

fmoura commented Aug 23, 2023

@gligneul Built has some information about the build that we could log. But I think the more consistent ones are "package version" and "build time"

There is a "git version", "git branch" that are available if the build is from a git repo, which is not the case when building using Docker Buildx Bake.

Should I stick to only "package version" for now?

@gligneul
Copy link
Contributor Author

Yes, only the package version is fine. I don't like the idea of using build time.

@gligneul gligneul modified the milestones: 1.1.0, 1.2.0 Sep 28, 2023
@fmoura fmoura linked a pull request Oct 1, 2023 that will close this issue
@fmoura fmoura closed this as completed in #86 Oct 5, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Node Unit Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants