Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable send transaction when user is on the wrong network #295

Open
5 tasks
nevendyulgerov opened this issue Jan 10, 2025 · 0 comments · May be fixed by #296
Open
5 tasks

Disable send transaction when user is on the wrong network #295

nevendyulgerov opened this issue Jan 10, 2025 · 0 comments · May be fixed by #296
Assignees
@nevendyulgerov
Labels
apps: web Type: Feature Add a new feature to the system

Comments

@nevendyulgerov
Copy link
Contributor

nevendyulgerov commented Jan 10, 2025 •
edited
Loading

📄 Context

Currently, if you select a network different than the currently configured one for the app instance, you can still access the send transactions forms/modal:

send-transaction-on-wrong-network

send-transaction-modal

I think we should disallow this and disable the Send Transaction button in this case.

📈 Subtasks

  • Disable the Send Transaction button when wrong network is selected.
  • Add unit tests for the change.

🎯 Definition of Done

  • I can't send a transaction when I've selected the wrong network.
  • All unit tests are passing.
  • Vercel preview is working as expected.
@nevendyulgerov nevendyulgerov added Type: Feature Add a new feature to the system apps: web labels Jan 10, 2025
@nevendyulgerov nevendyulgerov self-assigned this Jan 10, 2025
@github-project-automation github-project-automation bot moved this to 📌 Todo in Explorer Unit Jan 10, 2025
@nevendyulgerov nevendyulgerov moved this from 📌 Todo to 🧑‍💻 In Progress in Explorer Unit Jan 10, 2025
@nevendyulgerov nevendyulgerov moved this from 🧑‍💻 In Progress to 👁 In Review in Explorer Unit Jan 10, 2025
@nevendyulgerov nevendyulgerov linked a pull request Jan 10, 2025 that will close this issue
#295 Disable send transaction button when network is wrong #296
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nevendyulgerov nevendyulgerov

Labels
apps: web Type: Feature Add a new feature to the system
Projects
Explorer Unit
Status: 👁 In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#295 Disable send transaction button when network is wrong cartesi/rollups-explorer
1 participant
@nevendyulgerov