Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade solidity pragma to ^0.8.13 #138

Closed
ZzzzHui opened this issue Nov 13, 2023 · 2 comments · Fixed by #243
Closed

Upgrade solidity pragma to ^0.8.13 #138

ZzzzHui opened this issue Nov 13, 2023 · 2 comments · Fixed by #243
Assignees
Labels
A-contracts Area: contracts T-feature Type: feature
Milestone

Comments

@ZzzzHui
Copy link
Contributor

ZzzzHui commented Nov 13, 2023

@guidanoli proposed to use a type-safe way to encode function calls (see here), which is already adopted in branch feature/blockchain-agnostic-inputs.
Since this new feature abi.encodeCall was introduced in 0.8.11 and bug fixed in 0.8.13 (ref), we'll upgrade solidity to pragma solidity ^0.8.13;

@ZzzzHui ZzzzHui added the T-feature Type: feature label Nov 13, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Rollups Unit Nov 13, 2023
@ZzzzHui ZzzzHui self-assigned this Nov 13, 2023
@ZzzzHui ZzzzHui added this to the 2.0.0 milestone Nov 13, 2023
@guidanoli guidanoli added D-easy A-contracts Area: contracts labels Nov 13, 2023
@guidanoli
Copy link
Collaborator

guidanoli commented Nov 17, 2023

You can upgrade the pragma of all contracts, since they are all connected to contracts that will need to be redeployed for v2 anyway. :-)

@guidanoli guidanoli modified the milestones: 2.0.0, 3.0.0 Nov 22, 2023
@guidanoli
Copy link
Collaborator

Actually, now v2 will not trigger a redeployment of all contracts.
Therefore, let's only fix this by the end of v2, only for the contracts that were changed.

@guidanoli guidanoli modified the milestones: 2.0.0, 3.0.0 Dec 8, 2023
@guidanoli guidanoli modified the milestones: 3.0.0, 2.0.0 Jan 21, 2024
@ZzzzHui ZzzzHui linked a pull request Jan 31, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🚀 Done in Rollups Unit Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contracts Area: contracts T-feature Type: feature
Projects
Status: 🚀 Done
Development

Successfully merging a pull request may close this issue.

2 participants