-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pictures are not displayed in Chrome #301
Comments
Be glad for that... Downloading the latest and the share button dosen´t even display for me in either Safari nor Firefox on El Capitan! :/ |
It also doesn't work on IE11 nor Edge browsers, but works for me in Safari. As per #250 there seems to be untested new version that has improved cross-browser compatibility. Unfortunately I am not able to test it as it requires a build environment to create distribution files, and I was not successful in creating one. |
I have the same issue. On Chrome 50, and IE - icons are invisible. So here's a workaround that I did. I took the SVG images from the repo, I added a second version of each (example: pinterest-light.svg) that's the same, but white (with fill="white") and finally I overrode the messed-up plugin styles - updating the background-image with the external SVGs that I placed in my project share-button .sb-social li[class*='pinterest']:after {
background-image: url('/img/share-button/pinterest.svg');
}
share-button .sb-social li[class*='pinterest']:before {
background-image: url('/img/share-button/pinterest-light.svg');
} So I did this steps for all icons that I needed. It works on Chrome, Firefox, Safari and IE latest. The only issue is that it 'costs' a few additional server (http) requests. But I guess, this is still better then not working at all :) And here's my full fix. Download the zip: share-button-svgs.zip and extract it in your images directory. Than paste this styles in your project stylesheet, making sure the url on your side is correct. /**
* Solves the issues with SVG as a background image,
* that doesn't display on Chrome 50 and IE latest.
* This way it works on Chrome, Firefox, Safari and IE latest.
*
* https://github.com/carrot/share-button/issues/301
*/
share-button .sb-social li[class*='pinterest']:after {
background-image: url('/img/share-button/pinterest.svg');
}
share-button .sb-social li[class*='pinterest']:before {
background-image: url('/img/share-button/pinterest-light.svg');
}
share-button .sb-social li[class*='twitter']:after {
background-image: url('/img/share-button/twitter.svg');
}
share-button .sb-social li[class*='twitter']:before {
background-image: url('/img/share-button/twitter-light.svg');
}
share-button .sb-social li[class*='facebook']:after {
background-image: url('/img/share-button/facebook.svg');
}
share-button .sb-social li[class*='facebook']:before {
background-image: url('/img/share-button/facebook-light.svg');
}
share-button .sb-social li[class*='googlePlus']:after {
background-image: url('/img/share-button/googlePlus.svg');
}
share-button .sb-social li[class*='googlePlus']:before {
background-image: url('/img/share-button/googlePlus-light.svg');
}
share-button .sb-social li[class*='email']:after {
background-image: url('/img/share-button/email.svg');
}
share-button .sb-social li[class*='email']:before {
background-image: url('/img/share-button/email-light.svg');
}
share-button .sb-social li[class*='linkedin']:after {
background-image: url('/img/share-button/linkedin.svg');
}
share-button .sb-social li[class*='linkedin']:before {
background-image: url('/img/share-button/linkedin-light.svg');
} |
I’m having the same issue as @nicolasbadia The icons show up in Safari and Firefox. But they aren’t appearing in Chrome. |
@shanetheboland You seem to have fixed this on your site. What was the solution? |
Found the answer in Issue #305. |
@shanetheboland Awesome thanks! |
When using the plugin in chrome there is no pictures visible.
I'm having the issue on my website and on the demo: https://sharebutton.co/
It seem to works fine in all other browser.
The text was updated successfully, but these errors were encountered: