Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange Errors With Jade #27

Open
joeyjoejoejr opened this issue Sep 21, 2015 · 7 comments
Open

Strange Errors With Jade #27

joeyjoejoejr opened this issue Sep 21, 2015 · 7 comments

Comments

@joeyjoejoejr
Copy link

I'm getting the same strange errors mentioned here:
jescalan/roots#662

and that are seemingly fixed in roots records here:
carrot/roots-records#22

I'll try to look into it when I get a chance, but I'm getting the same issue in roots-contentful

@kylemac
Copy link
Contributor

kylemac commented Oct 9, 2015

@joeyjoejoejr is this happening on the initial compile or only on subsequent compiles? I've run into a problem with only subsequent compiles lately and I'm trying to figure out whether they are the same issue or not

@joeyjoejoejr
Copy link
Author

Yeah, only subsequent compiles. The fix should be in the repo. We need to sanitize the locals that are passed into Jade. I haven't had a chance to look at it yet.

@kylemac
Copy link
Contributor

kylemac commented Oct 9, 2015

@joeyjoejoejr i'm not totally sure what you mean but based on what you say, it sounds like an issue here - https://github.com/carrot/roots-contentful/blob/master/lib/index.coffee#L137-L138

@joeyjoejoejr
Copy link
Author

It's actually right here:
https://github.com/carrot/roots-contentful/blob/master/lib/index.coffee#L154-L155

Where the locals are being passed into renderFile. The locals have some left-over data from roots that causes problems with the jade compiler. Specifically, I think, is the filename properly.

@kylemac
Copy link
Contributor

kylemac commented Oct 23, 2015

update for you @joeyjoejoejr - this one has been stickier than we expected. it has its hooks in accord and roots-core, but we're working on it. @hhsnopek has it in his sights

@zspecza
Copy link
Contributor

zspecza commented Jan 6, 2016

Is this issue still persistent? /cc @kylemac @hhsnopek @joeyjoejoejr

@hhsnopek
Copy link
Contributor

hhsnopek commented Jan 7, 2016

This was solved in roots - see the roots issue #662, for anyone that needs a working branch of roots that's still on v3.1.0 see: https://github.com/carrot/roots/tree/upstream-v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants