Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use datasets.R for adding information about data #56

Open
PabRod opened this issue Mar 25, 2022 · 1 comment
Open

Use datasets.R for adding information about data #56

PabRod opened this issue Mar 25, 2022 · 1 comment
Assignees
Labels
ch-data enhancement New feature or request low-priority To be reopened in the future

Comments

@PabRod
Copy link
Collaborator

PabRod commented Mar 25, 2022

Problem

We are including only one data set. This may obscure some questions, such as:

  • Do I need one documentation file in ./R per data set?
  • Does the file need to have the same name as the data set?
  • Does the file need to have the same name as the file where the data set is stored?

Solution

Store two data sets instead of one. One with the instructors names and another one with names from Star Wars. Document both from the same file, and name this file ./R/datasets.R.

@PabRod PabRod added enhancement New feature or request ch-data labels Mar 25, 2022
@bvreede bvreede self-assigned this Apr 14, 2022
@PabRod PabRod added the low-priority To be reopened in the future label May 30, 2022
@bvreede
Copy link
Collaborator

bvreede commented Jul 5, 2022

Another thought: instead of using data from instructors names, we can use e.g. the babynames package and sample it to get a list of names:
sample(babynames::babynames$name, 100)

A fringe benefit is that we have another package that can be listed as a (suggested) dependency :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ch-data enhancement New feature or request low-priority To be reopened in the future
Projects
None yet
Development

No branches or pull requests

2 participants