Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Improve style #165

Merged
merged 2 commits into from
Jul 19, 2021
Merged

STYLE: Improve style #165

merged 2 commits into from
Jul 19, 2021

Conversation

jhlegarreta
Copy link
Contributor

@jhlegarreta jhlegarreta commented Jul 9, 2021 •
edited
Loading

Improve style:

  • Change NBSP appearances to regular whitespaces
  • Add missing closing bracket

@jhlegarreta jhlegarreta requested review from kaitj and josephmje July 9, 2021 14:32
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jhlegarreta jhlegarreta mentioned this pull request Jul 9, 2021
Closed
@netlify
Copy link

netlify bot commented Jul 9, 2021 •
edited
Loading

✔️ Deploy Preview for carpentries-dmri ready!

🔨 Explore the source changes: bcfcf06

🔍 Inspect the deploy log: https://app.netlify.com/sites/carpentries-dmri/deploys/60f581d07129aa000718f477

😎 Browse the preview: https://deploy-preview-165--carpentries-dmri.netlify.app

@jhlegarreta jhlegarreta mentioned this pull request Jul 9, 2021
Merged
@kaitj
Copy link
Collaborator

kaitj commented Jul 15, 2021 •
edited
Loading

This looks good to me pending the fixes from #166

@jhlegarreta
STYLE: Change NBSP appearances to regular whitespaces
3e04437 
Change non-breaking space (`NBSP`) appearances to regular whitespaces.
@jhlegarreta
STYLE: Add missing closing bracket
bcfcf06 
Add missing closing bracket.
@jhlegarreta jhlegarreta merged commit 73bb0d4 into carpentries-incubator:main Jul 19, 2021
@jhlegarreta jhlegarreta deleted the ImproveStyle branch July 19, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmje josephmje josephmje approved these changes

@kaitj kaitj kaitj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhlegarreta @kaitj @josephmje