Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre-commit hook to validate the Jupyter notebooks #138

Open
jhlegarreta opened this issue Apr 14, 2021 · 0 comments
Open

Add a pre-commit hook to validate the Jupyter notebooks #138

jhlegarreta opened this issue Apr 14, 2021 · 0 comments
Labels
type:enhancement Propose enhancement to the lesson

Comments

@jhlegarreta
Copy link
Contributor

At times, we manually edit the raw Jupyter notebooks (like #137 (comment)) and break the notebooks and they effectively become unusable.

Although the CI tests in place would potentially detect such cases, this is not ideal; we would like the CI tests to spend time in executing the cells, rather than exiting because the file cannot be parsed.

Adding a pre-commit hook that is able to ensure that the files can at least be parsed could be a solution for this.

@jhlegarreta jhlegarreta added the type:enhancement Propose enhancement to the lesson label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Propose enhancement to the lesson
Projects
None yet
Development

No branches or pull requests

1 participant