Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backslash in (access) key leads to problems with URI #771

Open
golsch opened this issue Nov 30, 2023 · 1 comment
Open

Backslash in (access) key leads to problems with URI #771

golsch opened this issue Nov 30, 2023 · 1 comment
Labels
bug Something isn't working needs triage The issue needs to be triaged, before work can commence

Comments

@golsch
Copy link

golsch commented Nov 30, 2023

Bug Description

Unfortunately, our S3 implementation is dependent on another system, which means that there is a backslash in the access key. If you create an absolute URI for a path, this leads to problems because backslash is an illegal URI character.

Steps To Reproduce

  1. Initialize an S3 file system with a backslash in the access key, for example <ad\accesskey>
  2. Create an absolute path or URI for a path

Expected Behavior

Get an absolute path/URI

Question

Is the user info (<>@) in the URI even necessary?

@golsch golsch added bug Something isn't working needs triage The issue needs to be triaged, before work can commence labels Nov 30, 2023
@steve-todorov
Copy link
Collaborator

steve-todorov commented Dec 3, 2023

Hey @golsch ,

Doesn't escaping the \ character in the access key uri segment with \\ work for this case?

Re:question:

TL;DR - yes, it's necessary for the time being. You might want to have multiple instances that use different buckets, so yes. We have plans to refactor this at some point so it's a bit more convenient to use, but for now it's necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage The issue needs to be triaged, before work can commence
Projects
None yet
Development

No branches or pull requests

2 participants