Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate BigNumbers to TypeScript #6689

Open
4 of 6 tasks
matthewgallo opened this issue Jan 13, 2025 · 1 comment · May be fixed by #6734
Open
4 of 6 tasks

Migrate BigNumbers to TypeScript #6689

matthewgallo opened this issue Jan 13, 2025 · 1 comment · May be fixed by #6734

Comments

@matthewgallo
Copy link
Member

matthewgallo commented Jan 13, 2025

As we add Typescript support, want to call out a few helpful tips from the Carbon TypeScript guide that is largely relevant to our library as well.

Changing the extension via git

When changing the file extension — do not simply rename the file. Instead, change the extension via git.

For example,

git mv packages/ibm-products/src/components/ComponentName/ComponentName.js packages/ibm-products/src/components/ComponentName/ComponentName.tsx

Do not add types to internal components or functions

Testing changes

A few different options for testing changes —

  • At the bottom of a file, write a dummy component that uses the component that you’re converting to ensure that you can still pass all appropriate props.
  • Take a storybook example for a component, copy and paste it into the bottom of the .tsx file and validate whether or not it accepts the props as you’ve defined them.

Tasks

Preview Give feedback

Resources

Carbon’s guide on adding component types

@matthewgallo
Copy link
Member Author

Reference #4232 for past components that have migrated

@matthewgallo matthewgallo moved this from Needs triage 🧐 to Backlog 🌋 in Carbon for IBM Products Jan 13, 2025
@paul-balchin-ibm paul-balchin-ibm moved this from Backlog 🌋 to In progress in Carbon for IBM Products Jan 16, 2025
@paul-balchin-ibm paul-balchin-ibm linked a pull request Jan 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants