Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix border color in Datagrid frozen columns (code) #5327

Closed
2 tasks done
Tracked by #5324
elycheea opened this issue May 23, 2024 · 1 comment · Fixed by #5373
Closed
2 tasks done
Tracked by #5324

Fix border color in Datagrid frozen columns (code) #5327

elycheea opened this issue May 23, 2024 · 1 comment · Fixed by #5373
Assignees
Labels
component: Datagrid role: dev Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. type: bug 🐛 Something isn't working version: 1 Carbon 10 / v1 version: 2 Carbon 11 / v2

Comments

@elycheea
Copy link
Contributor

elycheea commented May 23, 2024

Originally shared by @jjennings7.

Package

Carbon for IBM Products

Description

In Carbon 10 and 11, the frozen column border color is incorrect in both Figma and the Storybook code.

Storybook / code

In v1.72.3 (Carbon 10), the border color is the correct hex value, #c6c6c6, but the wrong token is assigned, $disabled-02. In addition, the border does not extend into the header cell.
Screenshot 2024-05-22 at 3 50 35 PM

In 2.39.0 (Carbon 11), the border color is the correct hex value, #c6c6c6, but the wrong token is assigned, $disabled-02.
Screenshot 2024-05-22 at 3 50 50 PM

Expected behavior
The right border should be $active-light-ui in v10 which seems to translate to $border-subtle in v11. The border should be present on the entire frozen column, including the header cell.

Resources
In issues #1980 and #2509, $active-light-ui is indicated as the correct border color. This information is also published in the PAL guidance.

Component(s) impacted

Storybook
v1.72.3 (Carbon 10) - Datagrid - Frozen columns
2.39.0 (Carbon 11) - Datagrid - Frozen columns

Browser

Chrome

@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version

all

Severity

Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.

Product/offering

DataStage

CodeSandbox or Stackblitz example

https://ibm-products.carbondesignsystem.com/?path=/story/ibm-products-components-datagrid--frozen-columns&globals=viewport:basic

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

Tasks

Preview Give feedback
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products May 23, 2024
@elycheea elycheea added version: 2 Carbon 11 / v2 version: 1 Carbon 10 / v1 type: bug 🐛 Something isn't working Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. and removed status: needs triage 🕵️‍♀️ labels May 23, 2024
@elycheea elycheea moved this from Needs triage 🧐 to Backlog 🌋 in Carbon for IBM Products May 23, 2024
@elycheea
Copy link
Contributor Author

Note that we can have frozen columns both on the right and left side. The left frozen columns are shown in the screenshots whereas the right frozen columns can be seen in row action stories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Datagrid role: dev Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. type: bug 🐛 Something isn't working version: 1 Carbon 10 / v1 version: 2 Carbon 11 / v2
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants