fix: Enhancement in color page token #4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey reviewer , Please review the notification table and there hex code as this is newly added. Please verify 2 links added in the the description of component tokens and ai tokens are correct or not. Please check if the tokens are correctly categorised and navigating to the correct table. |
aagonzales
reviewed
Aug 27, 2024
src/pages/elements/color/tokens.mdx
Outdated
Comment on lines
56
to
58
| <a href="https://github.com/carbon-design-system/carbon/blob/main/packages/styles/docs/sass.md#component-tokens"> | ||
| developer documentation{' '} | ||
| </a> for more information. |
There was a problem hiding this comment.
Should be able to switch these links to markdown syntax to fix the line break vs html.
[developer documentation](https://github.com/carbon-design-system/carbon/blob/main/packages/styles/docs/sass.md#component-tokens)
src/pages/elements/color/tokens.mdx
Outdated
| Core tokens are global colors that are used across components. They are named | ||
| and grouped by the common UI element that they are applied to. | ||
|
|
||
| <AnchorLinks> |
There was a problem hiding this comment.
Suggested change
| <AnchorLinks> | |
| <AnchorLinks small> |
alisonjoseph
requested changes
Aug 29, 2024
Co-authored-by: Alison Joseph <[email protected]>
Co-authored-by: Alison Joseph <[email protected]>
OOPs small ones :( |
alisonjoseph
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4110
Color Page Enhancements
Changelog
New
-Multiple H2 sections for Core, Component, and AI tokens
-Adding H3 anchor links inline with the H3 token headers in tables.
-Adding H3 mini-anchor link sections for easier navigation.
-Addition of a table under component tokens called "notification"