Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update pagination style tab #4196

Merged
merged 19 commits into from
Aug 15, 2024
Merged

docs: update pagination style tab #4196

merged 19 commits into from
Aug 15, 2024

Conversation

laurenmrice
Copy link
Member

Closes #4021

  • This PR updates the pagination component Style tab documentation with using the content template.
  • It adds in pagination nav as another variant.

Changelog

New

  • Added the pagination nav variant
  • Added many sections throughout the doc

Changed

  • Content and images

Removed

  • Content and images that are no longer relevant

@laurenmrice laurenmrice requested review from a team as code owners August 13, 2024 04:46
@vercel Vercel
Copy link

vercel bot commented Aug 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 6:07pm

@laurenmrice laurenmrice requested a review from thyhmdo August 13, 2024 04:46
@laurenmrice
Copy link
Member Author

Hey @emyarod or @alisonjoseph , when one of you get a chance can you see why my vercel deployment keeps failing? I can't seem to figure it out. Thanks!

@emyarod
Copy link
Member

emyarod commented Aug 13, 2024

@laurenmrice it looks like pagination-usage-sizes.png is missing from the repo!

@laurenmrice laurenmrice requested review from alisonjoseph and removed request for alina-jacob August 13, 2024 20:44
emyarod
emyarod approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

thyhmdo
thyhmdo reviewed Aug 14, 2024
View reviewed changes
src/pages/components/pagination/style.mdx Outdated Show resolved Hide resolved
src/pages/components/pagination/style.mdx Outdated Show resolved Hide resolved
src/pages/components/pagination/style.mdx Outdated Show resolved Hide resolved
src/pages/components/pagination/style.mdx Outdated Show resolved Hide resolved
src/pages/components/pagination/style.mdx Show resolved Hide resolved
@laurenmrice laurenmrice requested a review from thyhmdo August 15, 2024 01:00
thyhmdo
thyhmdo approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@thyhmdo thyhmdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kodiakhq kodiakhq bot merged commit 55346a9 into carbon-design-system:main Aug 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thyhmdo thyhmdo thyhmdo approved these changes

@emyarod emyarod emyarod approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pagination, PaginationNav] update Style docs
4 participants
@laurenmrice @emyarod @alisonjoseph @thyhmdo