Update accessibility.mdx #4184
Update accessibility.mdx #4184
Conversation
Tried moving the accessibility status to the bottom of the page, as per #3960 Since the H3 is generated in code, I'm just leaving it as is. Expectation is that this will be a subsection of Development considerations, which works fine. Not showing up in preview.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
If we're moving this section to the bottom (and updating to a h2) we probably should add an anchor link for "Accessibility testing status" to the top of these pages also. |
Note that I am not altering the content here at all (not making it an H2). I'm just repositioning I agree the H2 and TOC could take place, but that requires additional changes that I cannot do on my lonesome. This first step could be done across the board by me easily, and it would set up all the pages to later be updated to H2 (which I think is just one global change). I think the TOC would need to be done manually per page, although could be done as one GSR, in all likelihood. And finally, note that this repositioning is clean. The page works that way -- in fact the existing H3 for the accessibility testing makes hierarchical sense where I reposition it, while it makes no sense in its current location |
There was a problem hiding this comment.
Hi @mbgower! This looks good 🎉
Just a quick confirmation—will the change in this PR need to be updated in all the other components as well?
|
@Kritvi-bhatia17 @mbgower Yes, I believe he said he would make the change in this PR for all of them, once we agreed on a direction. So we should wait to merge. |
Changed 28 components that were previously revised to the standard accessibility tab layout
Move the accessibility testing to the bottom of pages that have not been updated to the current accessibility tab template
A number of pages had the A11yStatus formed with indented code, so my GSR failed to locate. As well, a manual check of each page (which I did by navigating to the Accessibility tab and clicking the Development considerations on-page link), showed that a few of the on-page links were malformed.
…stem/carbon-website into mbgower-patch-1
Missed popover testing section
|
@laurenmrice I've now repositioned on all relevant pages, and cleaned up a couple of in-page links at the same time. |
These five components had not had their Accessibility tab info updated due to various reasons. We elected to strip out the old testing results. I left the H2 for Testing in place.
|
@laurenmrice I've removed the legacy testing material from those five. I left the "Accessibility testing" H2 in place, but stripped out its paragraph of text (since it wasn't always accurate, based on the results) and just followed up immediately with the H3 of the "Accessibility testing status". It's not beautiful, but seemed like the least inelegant of the solutions for these five ugly duckling topics. :)
I don't understand this. The updated page looks fine to me? |
Adding top description to list component.
…stem/carbon-website into mbgower-patch-1
Tried moving the accessibility status to the bottom of the page, as per #3960
Since the H3 is generated in code, I'm just leaving it as is. This becomes a subsection of Development considerations, which works fine.
https://carbondesignsystem-git-mbgower-patch-1-carbon-design-system.vercel.app/components/accordion/accessibility
Closes #3960