Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: add guidance for not having danger icon only buttons #4176

Open
2 tasks done
Tracked by #14300
laurenmrice opened this issue Jul 24, 2024 · 0 comments
Open
2 tasks done
Tracked by #14300

Button: add guidance for not having danger icon only buttons #4176

laurenmrice opened this issue Jul 24, 2024 · 0 comments

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Jul 24, 2024

Acceptance criteria

We do not support danger icon only buttons in code. A common question has come up from our users why we do not support this and we need to be more clear about the reasoning behind this in our website documentation.

Tasks

  • Add guidance to the Button Usage tab of why we do not support danger icon only buttons. This section might be a good place to explain this.
  • Add some images (like Don/Dont images) to support this reasoning.
  • Some reasons why we don't support this:
    • We believe that danger can be a critical action and should be applied to a button a higher emphasis that also includes a visual label, like a primary, tertiary, or ghost button.
    • There has sometimes been confusion on what color to use for the different states in a UI. Sometimes we have seen product teams using the default ghost button color tokens for the enabled state, while the danger color tokens appear on hover, which feels disjointed and is inaccurate.
@laurenmrice laurenmrice transferred this issue from carbon-design-system/carbon Jul 24, 2024
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Jul 24, 2024
@laurenmrice laurenmrice moved this to ⏱ Backlog in Design System Jul 24, 2024
@laurenmrice laurenmrice added this to the 2024 Q3 milestone Jul 24, 2024
@laurenmrice laurenmrice moved this from Triage to Next in Roadmap Jul 24, 2024
@laurenmrice laurenmrice moved this from Next to Later in Roadmap Jul 24, 2024
@sstrubberg sstrubberg moved this from Later to Icebox 🧊 in Roadmap Sep 11, 2024
@sstrubberg sstrubberg moved this from Later 🧊 to Next ➡ in Roadmap Sep 16, 2024
@sstrubberg sstrubberg removed this from Roadmap Sep 16, 2024
@sstrubberg sstrubberg modified the milestones: 2024 Q3, 2024 Q4 Sep 16, 2024
@sstrubberg sstrubberg modified the milestones: 2024 Q3, 2024 Q4 Oct 2, 2024
@alina-jacob alina-jacob self-assigned this Oct 9, 2024
@alina-jacob alina-jacob moved this from 🚦 In Review to 🏗 In Progress in Design System Nov 20, 2024
@alina-jacob alina-jacob moved this from 🏗 In Progress to 🚦 In Review in Design System Dec 19, 2024
@laurenmrice laurenmrice modified the milestones: 2024 Q4, 2025 Q1 Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚦 In Review
Development

No branches or pull requests

3 participants