Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update pagination usage tab #4175

Merged
merged 15 commits into from
Aug 13, 2024
Merged

docs: update pagination usage tab #4175

merged 15 commits into from
Aug 13, 2024

Conversation

laurenmrice
Copy link
Member

@laurenmrice laurenmrice commented Jul 22, 2024 •
edited
Loading

Closes #4013

  • This PR updates the pagination component Usage tab documentation with using the content template.
  • It adds in pagination nav as another variant.
  • It addresses the a11y review that was originally done on this components usage tab.

Changelog

New

  • Added the pagination nav variant
  • Added many sections throughout the doc

Changed

  • Content and images

Removed

  • Content and images that are no longer relevant

@laurenmrice laurenmrice requested review from a team as code owners July 22, 2024 19:51
@vercel Vercel
Copy link

vercel bot commented Jul 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 8:42pm

@laurenmrice laurenmrice requested a review from thyhmdo July 22, 2024 19:52
aagonzales
aagonzales requested changes Jul 23, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few small things to fix.

src/pages/components/pagination/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/pagination/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/pagination/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/pagination/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/pagination/usage.mdx Show resolved Hide resolved
src/pages/components/pagination/usage.mdx Show resolved Hide resolved
src/pages/components/pagination/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/pagination/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/pagination/usage.mdx Show resolved Hide resolved
src/pages/components/pagination/usage.mdx Outdated Show resolved Hide resolved
@laurenmrice laurenmrice requested a review from thyhmdo August 12, 2024 21:54
@laurenmrice laurenmrice requested a review from aagonzales August 12, 2024 22:27
guidari
guidari approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

aagonzales
aagonzales approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good to me now too!

@kodiakhq kodiakhq bot merged commit a233b53 into carbon-design-system:main Aug 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidari guidari guidari approved these changes

@aagonzales aagonzales aagonzales approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@thyhmdo thyhmdo Awaiting requested review from thyhmdo

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pagination, PaginationNav] update Usage docs
5 participants
@laurenmrice @alisonjoseph @aagonzales @guidari @thyhmdo