Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FormItem Toggle] Support Single Line Toggle #153

Closed
dabrad26 opened this issue Sep 19, 2023 · 2 comments · Fixed by #169
Closed

[FormItem Toggle] Support Single Line Toggle #153

dabrad26 opened this issue Sep 19, 2023 · 2 comments · Fixed by #169
Assignees
@dabrad26
Labels
Enhancement Review Pending code review before closing.

Comments

@dabrad26
Copy link
Member

Need to support single line toggle where label, value and toggle are in one line. This maybe should be split off?

https://www.figma.com/file/O3KSDu2TWpMaazGkgsKqLA/(Beta)-Carbon-Native---Carbon-Design-System?type=design&node-id=1880-7275&mode=design&t=pvRvKD3b6bie0LLb-0

Screenshot 2023-09-19 at 12 09 39
@dabrad26 dabrad26 self-assigned this Nov 29, 2023
@dabrad26 dabrad26 added the Review Pending code review before closing. label Nov 29, 2023
@dabrad26
Copy link
Member Author

dabrad26 commented Nov 29, 2023 •
edited
Loading

Added. FormItem has new type toggle-inline.

Screenshot 2023-11-29 at 12 13 16

 * `toggle-inline` - Toggle inline (single line) field. Label and toggle are on single line (not stacked)

@dabrad26
Copy link
Member Author

Does not support left toggle side.

dabrad26 added a commit that referenced this issue Nov 29, 2023
@dabrad26
fix(#128 #124 #153): form item design fixes and notification buttons
b891471
dabrad26 added a commit that referenced this issue Nov 29, 2023
@dabrad26
fix(#128 #124 #153): form item design fixes and notification buttons
2c3f733
@dabrad26 dabrad26 mentioned this issue Nov 29, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 29, 2023
@dabrad26
fix(#128 #124 #153): form item design fixes and notification buttons (#…
1baea8b 
…169)
@github-project-automation github-project-automation bot moved this from Todo to Done in Carbon for React Native Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dabrad26 dabrad26

Labels
Enhancement Review Pending code review before closing.
Projects
Carbon for React Native
Status: Done
Milestone
No milestone
1 participant
@dabrad26