Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tsconfig file within component package to generate the TS declaration files #344

Merged

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Dec 30, 2024

Closes #265

To generate the d.ts declaration files in the rollup output, each component package needs to have a tsconfig.json file. This adds some duplication but seems like it is necessary to get the output with the correct folder structure.

Changelog

New

  • add a tsconfig.json file within the component package

Changed

  • use the usePrefix hook that's now in the @carbon-labs/utilities package
  • moved the stackblitz link lower in the storybook mdx file for the ExampleButton

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for carbon-labs-react ready!

Name Link
🔨 Latest commit d27f66b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-labs-react/deploys/67730690e41dee00082117ea
😎 Deploy Preview https://deploy-preview-344--carbon-labs-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for carbon-labs-web-components ready!

Name Link
🔨 Latest commit d27f66b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-labs-web-components/deploys/677306903371d40008ea2289
😎 Deploy Preview https://deploy-preview-344--carbon-labs-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@carbon-design-system carbon-design-system deleted a comment from netlify bot Dec 30, 2024
@carbon-design-system carbon-design-system deleted a comment from netlify bot Dec 30, 2024
@annawen1 annawen1 merged commit d31d8d6 into carbon-design-system:main Dec 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant