chore(chat): Code functionailty fixes, Chart updates, Formula render fix #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-labs-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-labs-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ethanwinters
approved these changes
Jan 6, 2025
| /** | ||
| * startMathJax - edit target document for rendering | ||
| */ | ||
| async startMathJax() { |
There was a problem hiding this comment.
import 'mathjax/es5/tex-mml-chtml.js'; still pollute the global "window" object. This means that if the chat is running along side other code that uses mathjax (not a crazy thought) that they will clobber each other. Going to approve the PR, but we gotta work this out or move to katex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chore(chat): Code functionailty fixes, Chart updates, Formula render fix
Decription
For Code:
For Charts:
For Footer: external re-focus control
For Formula: Targeting shadowDOM instead of global window to avoid DOM leakage
For Popup: Styling updates up to Design standards