Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated build-info.json with correct icons and classification #159

Open
metonym opened this issue Feb 27, 2023 · 0 comments
Open

Fix generated build-info.json with correct icons and classification #159

metonym opened this issue Feb 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@metonym
Copy link
Collaborator

metonym commented Feb 27, 2023

This was flagged in #158 (review)

The current build-info.json generated by index.ts is used by the documentation site. The impact of this bug is that the documentation site for icons may omit/misclassify certain icons.

The current script relies on the module name from @carbon/icons/metadata.json to categorize modules into glyphs or icons. It should instead use the metadata from that file to determine the groupings.

{
  "name": "low-severity",
  "friendlyName": "Low severity",
  "sizes": [
    "glyph"
  ]
  // ...
}
@metonym metonym added the bug Something isn't working label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant