From 267135661afc95e2706284c8271eb8f6fca62f94 Mon Sep 17 00:00:00 2001 From: Andy Blum Date: Wed, 30 Oct 2024 16:21:07 -0400 Subject: [PATCH 1/4] fix(megamenu-tab): change default value override method --- .../src/components/masthead/megamenu-tab.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/web-components/src/components/masthead/megamenu-tab.ts b/packages/web-components/src/components/masthead/megamenu-tab.ts index 5f3066db4ae..a5fd917e4ba 100644 --- a/packages/web-components/src/components/masthead/megamenu-tab.ts +++ b/packages/web-components/src/components/masthead/megamenu-tab.ts @@ -25,11 +25,11 @@ const { stablePrefix: c4dPrefix } = c4dSettings; */ @customElement(`${c4dPrefix}-megamenu-tab`) class C4DMegaMenuTab extends CDSTab { - /** - * Disable unneeded properties inherited from CDS Content Switcher Item. - */ - closeOnActivation = false; - hideDivider = false; + + connectedCallback() { + this.closeOnActivation = false; + this.hideDivider = false; + } render() { const { disabled, selected, value } = this; From 0b05e7143ac0a9e734b3d7336f39dc98d4bbd36a Mon Sep 17 00:00:00 2001 From: Andy Blum Date: Fri, 1 Nov 2024 08:57:23 -0400 Subject: [PATCH 2/4] revert --- .../web-components/src/components/masthead/megamenu-tab.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/web-components/src/components/masthead/megamenu-tab.ts b/packages/web-components/src/components/masthead/megamenu-tab.ts index a5fd917e4ba..c441ea1d164 100644 --- a/packages/web-components/src/components/masthead/megamenu-tab.ts +++ b/packages/web-components/src/components/masthead/megamenu-tab.ts @@ -25,11 +25,8 @@ const { stablePrefix: c4dPrefix } = c4dSettings; */ @customElement(`${c4dPrefix}-megamenu-tab`) class C4DMegaMenuTab extends CDSTab { - - connectedCallback() { - this.closeOnActivation = false; - this.hideDivider = false; - } + closeOnActivation = false; + hideDivider = false; render() { const { disabled, selected, value } = this; From f80f287b21bd753c203368c7676e3ca5c64a6b82 Mon Sep 17 00:00:00 2001 From: Andy Blum Date: Fri, 1 Nov 2024 09:09:29 -0400 Subject: [PATCH 3/4] fix(megamenu-tab): revert revert, add super call --- .../src/components/masthead/megamenu-tab.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/web-components/src/components/masthead/megamenu-tab.ts b/packages/web-components/src/components/masthead/megamenu-tab.ts index c441ea1d164..db02d40ee4d 100644 --- a/packages/web-components/src/components/masthead/megamenu-tab.ts +++ b/packages/web-components/src/components/masthead/megamenu-tab.ts @@ -25,8 +25,12 @@ const { stablePrefix: c4dPrefix } = c4dSettings; */ @customElement(`${c4dPrefix}-megamenu-tab`) class C4DMegaMenuTab extends CDSTab { - closeOnActivation = false; - hideDivider = false; + + connectedCallback() { + super.connectedCallback(); + this.closeOnActivation = false; + this.hideDivider = false; + } render() { const { disabled, selected, value } = this; From 366b7eae1e644d60ebc3b949a2b5679f4a6c2a14 Mon Sep 17 00:00:00 2001 From: Matthew Oliveira Date: Tue, 19 Nov 2024 09:55:59 -0500 Subject: [PATCH 4/4] chore(megamenu-tab): code formatting fix --- packages/web-components/src/components/masthead/megamenu-tab.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/web-components/src/components/masthead/megamenu-tab.ts b/packages/web-components/src/components/masthead/megamenu-tab.ts index db02d40ee4d..164f05c5e8e 100644 --- a/packages/web-components/src/components/masthead/megamenu-tab.ts +++ b/packages/web-components/src/components/masthead/megamenu-tab.ts @@ -25,7 +25,6 @@ const { stablePrefix: c4dPrefix } = c4dSettings; */ @customElement(`${c4dPrefix}-megamenu-tab`) class C4DMegaMenuTab extends CDSTab { - connectedCallback() { super.connectedCallback(); this.closeOnActivation = false;