Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filter Panel]: Behavior #9040

Closed
2 tasks done
cedricpelle opened this issue Jun 27, 2022 · 2 comments · Fixed by #11057
Closed
2 tasks done

[Filter Panel]: Behavior #9040

cedricpelle opened this issue Jun 27, 2022 · 2 comments · Fixed by #11057
Labels
bug Something isn't working dev Needs some dev work inactive owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package

Comments

@cedricpelle
Copy link

cedricpelle commented Jun 27, 2022

JIRA

Description

Behavior when selected and un-selected item , section is opened

Component(s) impacted

Filter Panel

Browser

Chrome, Safari, Firefox, Microsoft Edge

Carbon for IBM.com version

v1.19.0

Severity

Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.

Application/website

https://www.ibm.com/support/customer/csol/terms/

Package

@carbon/ibmdotcom-web-components

CodeSandbox example

https://www.ibm.com/standards/carbon/web-components/?path=/docs/components-filter-panel--default

Steps to reproduce the issue (if applicable)

  • select an item

image

  • remove and close the section
    image

  • select an item into the second section
    image

==> and the component will reopen the first section (even nothing is selected )

Release date (if applicable)

No response

Code of Conduct

@cedricpelle cedricpelle added bug Something isn't working dev Needs some dev work labels Jun 27, 2022
@cedricpelle
Copy link
Author

I did a typo on the release, it should be v1.35

@kennylam kennylam added the package: web components Work necessary for the IBM.com Library web components package label Jun 28, 2022
@stale
Copy link

stale bot commented May 27, 2023

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label May 27, 2023
@andy-blum andy-blum added the owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants label Oct 12, 2023
@kodiakhq kodiakhq bot closed this as completed in #11057 Oct 26, 2023
kodiakhq bot pushed a commit that referenced this issue Oct 26, 2023
### Related Ticket(s)

Closes #10669 
Closes #9040
[Jira ADCMS-4089](https://jsw.ibm.com/browse/ADCMS-4089)
[Jira ADCMS-4084](https://jsw.ibm.com/browse/ADCMS-4084)

### Description

Reduces DOM node counts for the filter panel by only rendering the mobile or destop experience according to viewport. In order to acheive this, does a bit of refactoring how the heading is handled. Before the desktop and mobile layouts were coupled by only the mobile layout rendering the heading slot.

### Changelog

**Changed**

- Filter panel only renders desktop / mobile layout per the viewport

### Testing instructions

- [ ] Regression testing the Filter Panel
- [ ] Inspect the DOM. Only markup for desktop or mobile should be present, never both.
kennylam pushed a commit that referenced this issue Oct 28, 2023
### Related Ticket(s)

Closes #10669 
Closes #9040
[Jira ADCMS-4089](https://jsw.ibm.com/browse/ADCMS-4089)
[Jira ADCMS-4084](https://jsw.ibm.com/browse/ADCMS-4084)

### Description

Reduces DOM node counts for the filter panel by only rendering the mobile or destop experience according to viewport. In order to acheive this, does a bit of refactoring how the heading is handled. Before the desktop and mobile layouts were coupled by only the mobile layout rendering the heading slot.

### Changelog

**Changed**

- Filter panel only renders desktop / mobile layout per the viewport

### Testing instructions

- [ ] Regression testing the Filter Panel
- [ ] Inspect the DOM. Only markup for desktop or mobile should be present, never both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work inactive owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants