[c4d-image]: Image is forced to 4/3 aspect ratio #11960
Assignees
Labels
adopter: AEM
used when component or pattern will be used by this adopter
bug
Something isn't working
dev
Needs some dev work
owner: Innovation Team
used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants
package: web components
Work necessary for the IBM.com Library web components package
severity 3
Affects minor functionality, has a workaround
Comments
andy-blum
added
severity 3
kodiakhq bot
pushed a commit
that referenced
this issue
Aug 28, 2024
### Related Ticket(s) Closes # #11960 [JIRA](https://jsw.ibm.com/browse/ADCMS-5976) ### Description PR to fix issue where the image component aspect ratio was not changing ### Changelog **Removed** Styles causing the issue
annawen1
pushed a commit
that referenced
this issue
Sep 3, 2024
* fix(image): fix aspect ratio not changing (#11992) ### Related Ticket(s) Closes # #11960 [JIRA](https://jsw.ibm.com/browse/ADCMS-5976) ### Description PR to fix issue where the image component aspect ratio was not changing ### Changelog **Removed** Styles causing the issue * feat(card): add subcomponents shadow parts * chore(card): add "caption" part * chore(card): update unit tests --------- Co-authored-by: Carbon for IBM.com Bot <[email protected]> Co-authored-by: Andy Blum <[email protected]>
bruno-amorim
pushed a commit
to bruno-amorim/carbon-for-ibm-dotcom
that referenced
this issue
Sep 4, 2024
* fix(image): fix aspect ratio not changing (carbon-design-system#11992) ### Related Ticket(s) Closes # carbon-design-system#11960 [JIRA](https://jsw.ibm.com/browse/ADCMS-5976) ### Description PR to fix issue where the image component aspect ratio was not changing ### Changelog **Removed** Styles causing the issue * feat(card): add subcomponents shadow parts * chore(card): add "caption" part * chore(card): update unit tests --------- Co-authored-by: Carbon for IBM.com Bot <[email protected]> Co-authored-by: Andy Blum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://jsw.ibm.com/browse/ADCMS-5976
Description
c4d-image component appears to be forcing a 4/3 aspect ratio using the position-absolute-and-padding-top trick.
This results in the component ignoring the rendered image's intrinsic aspect ratio and always displaying as 4/3. This style appears to have been introduced in a merge commit
Component(s) impacted
c4d-image
Browser
Firefox
Carbon for IBM.com version
2.11.1
Severity
Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.
Application/website
ibm.com
Package
@carbon/ibmdotcom-web-components
CodeSandbox example
https://www.ibm.com/standards/carbon/web-components/?path=/story/components-image--default&knob-CTA%20style%20(cta-style)=button&knob-CTA%20type%20(cta-type)=local&knob-Content%20link%20href%20(href)=https://www.example.com&knob-Copy%20(copy):=Lorem%20ipsum%20dolor%20sit%20amet
Steps to reproduce the issue (if applicable)
No response
Release date (if applicable)
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: